[From nobody Sat Dec 21 12:00:23 2013 From: Michal Minar <reviewboard@gallagherhome.com> Precedence: list MIME-Version: 1.0 To: Michal Minar <miminar@redhat.com>, =?utf-8?b?VG9tw6HFoSBCxb5hdGVr?= <tbzatek@redhat.com>, OpenLMI Developers <openlmi-reviews@lists.fedorahosted.org> References: <20131218142024.301552.18549@ex-std-node147.prod.rhcloud.com> In-Reply-To: <20131218142024.301552.18549@ex-std-node147.prod.rhcloud.com> Date: Fri, 20 Dec 2013 07:35:14 -0000 Reply-To: Michal Minar <miminar@redhat.com>, openlmi-reviews@lists.fedorahosted.org Message-ID: <20131220073514.301551.35425@ex-std-node147.prod.rhcloud.com> Content-Type: multipart/alternative; boundary="===============5257473530853099826==" Subject: Re: Review Request 1397: indmanager: Properly detach the manage thread from CIMOM Message: 45 --===============5257473530853099826== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1397/#review2041 ----------------------------------------------------------- Ship it! LTGM. - Michal Minar On Dec. 18, 2013, 2:20 p.m., Tomáš Bžatek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard-openlmi.rhcloud.com/r/1397/ > ----------------------------------------------------------- > > (Updated Dec. 18, 2013, 2:20 p.m.) > > > Review request for OpenLMI Developers. > > > Repository: openlmi-providers > > > Description > ------- > > indmanager: Properly detach the manage thread from CIMOM > > Accomplished that by registering a pthread cleanup handler that gets > called on thread cancellation as well as on normal exit. > > A minor code shuffle had to be done since the cleanup handlers are macros > in fact and no control flow commands (return, continue) should be called > within. > > -- > This is quite experimental stuff, handle with care. In worst case, the cleanup handler wouldn't get called resulting in the same state of things like before. > It's a pthread magic whose creators were very clever and nobody really understands it. > > > Diffs > ----- > > src/indmanager/ind_manager.c d6cd650290fe783995dc89390a096eb3e0ac8040 > > Diff: http://reviewboard-openlmi.rhcloud.com/r/1397/diff/ > > > Testing > ------- > > > Thanks, > > Tomáš Bžatek > > --===============5257473530853099826== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit <html> <body> <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;"> <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;"> <tr> <td> This is an automatically generated e-mail. To reply, visit: <a href="http://reviewboard-openlmi.rhcloud.com/r/1397/">http://reviewboard-openlmi.rhcloud.com/r/1397/</a> </td> </tr> </table> <br /> <p>Ship it!</p> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">LTGM.</pre> <br /> <p>- Michal Minar</p> <br /> <p>On December 18th, 2013, 2:20 p.m. UTC, Tomáš Bžatek wrote:</p> <table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://reviewboard-openlmi.rhcloud.com/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;"> <tr> <td> <div>Review request for OpenLMI Developers.</div> <div>By Tomáš Bžatek.</div> <p style="color: grey;"><i>Updated Dec. 18, 2013, 2:20 p.m.</i></p> <div style="margin-top: 1.5em;"> <b style="color: #575012; font-size: 10pt;">Repository: </b> openlmi-providers </div> <h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0"> <tr> <td> <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"> indmanager: Properly detach the manage thread from CIMOM Accomplished that by registering a pthread cleanup handler that gets called on thread cancellation as well as on normal exit. A minor code shuffle had to be done since the cleanup handlers are macros in fact and no control flow commands (return, continue) should be called within. -- This is quite experimental stuff, handle with care. In worst case, the cleanup handler wouldn&#39;t get called resulting in the same state of things like before. It&#39;s a pthread magic whose creators were very clever and nobody really understands it.</pre> </td> </tr> </table> <h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1> <ul style="margin-left: 3em; padding-left: 0;"> <li>src/indmanager/ind_manager.c <span style="color: grey">(d6cd650290fe783995dc89390a096eb3e0ac8040)</span></li> </ul> <p><a href="http://reviewboard-openlmi.rhcloud.com/r/1397/diff/" style="margin-left: 3em;">View Diff</a></p> </td> </tr> </table> </div> </body> </html> --===============5257473530853099826==-- ]