[From nobody Tue Dec 17 13:44:53 2013 From: Radek Novacek <reviewboard@gallagherhome.com> Precedence: list MIME-Version: 1.0 To: "Michal Minar" <miminar@redhat.com>, "OpenLMI Developers" <openlmi-reviews@lists.fedorahosted.org>, "Radek Novacek" <rnovacek@redhat.com> References: <20131215101723.301551.95445@ex-std-node147.prod.rhcloud.com> In-Reply-To: <20131215101723.301551.95445@ex-std-node147.prod.rhcloud.com> Date: Tue, 17 Dec 2013 07:49:45 -0000 Reply-To: Radek Novacek <rnovacek@redhat.com>, openlmi-reviews@lists.fedorahosted.org Message-ID: <20131217074945.301552.45346@ex-std-node147.prod.rhcloud.com> Content-Type: multipart/alternative; boundary="===============7506692949202051670==" Subject: Re: Review Request 1367: providers [2/5] software: make the checksum type retrieval more robust Message: 19 --===============7506692949202051670== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1367/#review1975 ----------------------------------------------------------- Ship it! src/software/lmi/software/yumdb/packagecheck.py <http://reviewboard-openlmi.rhcloud.com/r/1367/#comment1083> Nice! :) - Radek Novacek On Dec. 15, 2013, 11:17 a.m., Michal Minar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard-openlmi.rhcloud.com/r/1367/ > ----------------------------------------------------------- > > (Updated Dec. 15, 2013, 11:17 a.m.) > > > Review request for OpenLMI Developers. > > > Repository: openlmi-providers > > > Description > ------- > > software: make the checksum type retrieval more robust > > In some rare cases, digest algorithm is not set in rpm packages (happens > on rhel7). Try to deduce it from hash digest stored for installed files > and fallback to some sane default. > > In case it's not set, package use md5 digest algorithm for its files. > Provider failed to generate it correctly. The Checksum was doubled. > > Resolves: rhbz#1032590 > > > Diffs > ----- > > src/software/lmi/software/core/IdentityFileCheck.py 80324426dd2a755bef470febb4d69df00abfb826 > src/software/lmi/software/yumdb/packagecheck.py 0a7f351f3f5fb99085a770bb1384c11b97da15a6 > > Diff: http://reviewboard-openlmi.rhcloud.com/r/1367/diff/ > > > Testing > ------- > > TestSoftwareIdentityFileCheck.test_check_config on rhel7 > > > Thanks, > > Michal Minar > > --===============7506692949202051670== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit <html> <body> <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;"> <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;"> <tr> <td> This is an automatically generated e-mail. To reply, visit: <a href="http://reviewboard-openlmi.rhcloud.com/r/1367/">http://reviewboard-openlmi.rhcloud.com/r/1367/</a> </td> </tr> </table> <br /> <p>Ship it!</p> <div> <table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;"> <thead> <tr> <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;"> <a href="http://reviewboard-openlmi.rhcloud.com/r/1367/diff/1/?file=6969#file6969line225" style="color: black; font-weight: bold; text-decoration: underline;">src/software/lmi/software/yumdb/packagecheck.py</a> <span style="font-weight: normal;"> (Diff revision 1) </span> </th> </tr> </thead> <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;"> <tr> <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">def __setstate__(self, state):</pre></td> </tr> </tbody> <tbody> <tr> <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">225</font></th> <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="sd"> I just love yum API -- just kidding.</span></pre></td> </tr> </tbody> </table> <pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Nice! :)</pre> </div> <br /> <p>- Radek Novacek</p> <br /> <p>On December 15th, 2013, 11:17 a.m. CET, Michal Minar wrote:</p> <table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://reviewboard-openlmi.rhcloud.com/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;"> <tr> <td> <div>Review request for OpenLMI Developers.</div> <div>By Michal Minar.</div> <p style="color: grey;"><i>Updated Dec. 15, 2013, 11:17 a.m.</i></p> <div style="margin-top: 1.5em;"> <b style="color: #575012; font-size: 10pt;">Repository: </b> openlmi-providers </div> <h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0"> <tr> <td> <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">software: make the checksum type retrieval more robust In some rare cases, digest algorithm is not set in rpm packages (happens on rhel7). Try to deduce it from hash digest stored for installed files and fallback to some sane default. In case it&#39;s not set, package use md5 digest algorithm for its files. Provider failed to generate it correctly. The Checksum was doubled. Resolves: rhbz#1032590 </pre> </td> </tr> </table> <h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0"> <tr> <td> <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">TestSoftwareIdentityFileCheck.test_check_config on rhel7</pre> </td> </tr> </table> <h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1> <ul style="margin-left: 3em; padding-left: 0;"> <li>src/software/lmi/software/core/IdentityFileCheck.py <span style="color: grey">(80324426dd2a755bef470febb4d69df00abfb826)</span></li> <li>src/software/lmi/software/yumdb/packagecheck.py <span style="color: grey">(0a7f351f3f5fb99085a770bb1384c11b97da15a6)</span></li> </ul> <p><a href="http://reviewboard-openlmi.rhcloud.com/r/1367/diff/" style="margin-left: 3em;">View Diff</a></p> </td> </tr> </table> </div> </body> </html> --===============7506692949202051670==-- ]