[From nobody Thu Dec 12 12:23:33 2013 From: Tomas Smetana <reviewboard@gallagherhome.com> Precedence: list MIME-Version: 1.0 To: "Tomas Smetana" <tsmetana@redhat.com>, "OpenLMI Developers" <openlmi-reviews@lists.fedorahosted.org> Date: Wed, 11 Dec 2013 16:40:57 -0000 Reply-To: Tomas Smetana <tsmetana@redhat.com>, openlmi-reviews@lists.fedorahosted.org Message-ID: <20131211164057.6800.24652@ex-std-node147.prod.rhcloud.com> Content-Type: multipart/alternative; boundary="===============1241213630414164267==" Subject: Review Request 1350: Realmd: increase the D-Bus messages timeout Message: 67 --===============1241213630414164267== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1350/ ----------------------------------------------------------- Review request for OpenLMI Developers. Repository: openlmi-providers Description ------- This patch increases the timeout for all the D-Bus message send calls to DBUS_TIMEOUT_INFINITE. This means we wait for Realmd to finish the join/leave operations: it is hard to predict how long can those take and the default D-Bus timeout may not be enough. When the enrollment takes more than what's the D-Bus default timeout, the provider reports (false) failure even when the oprations succeeds. Diffs ----- src/realmd/rdcp_dbus.c 3df6803df70d3fdb524c491cfb511f42d429861c Diff: http://reviewboard-openlmi.rhcloud.com/r/1350/diff/ Testing ------- Thanks, Tomas Smetana --===============1241213630414164267== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit <html> <body> <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;"> <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;"> <tr> <td> This is an automatically generated e-mail. To reply, visit: <a href="http://reviewboard-openlmi.rhcloud.com/r/1350/">http://reviewboard-openlmi.rhcloud.com/r/1350/</a> </td> </tr> </table> <br /> <table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://reviewboard-openlmi.rhcloud.com/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;"> <tr> <td> <div>Review request for OpenLMI Developers.</div> <div>By Tomas Smetana.</div> <div style="margin-top: 1.5em;"> <b style="color: #575012; font-size: 10pt;">Repository: </b> openlmi-providers </div> <h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0"> <tr> <td> <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch increases the timeout for all the D-Bus message send calls to DBUS_TIMEOUT_INFINITE. This means we wait for Realmd to finish the join/leave operations: it is hard to predict how long can those take and the default D-Bus timeout may not be enough. When the enrollment takes more than what&#39;s the D-Bus default timeout, the provider reports (false) failure even when the oprations succeeds.</pre> </td> </tr> </table> <h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1> <ul style="margin-left: 3em; padding-left: 0;"> <li>src/realmd/rdcp_dbus.c <span style="color: grey">(3df6803df70d3fdb524c491cfb511f42d429861c)</span></li> </ul> <p><a href="http://reviewboard-openlmi.rhcloud.com/r/1350/diff/" style="margin-left: 3em;">View Diff</a></p> </td> </tr> </table> </div> </body> </html> --===============1241213630414164267==-- ]