[From nobody Tue Dec 3 13:40:34 2013 From: "=?utf-8?b?VG9tw6HFoSBCxb5hdGVr?=" <reviewboard@gallagherhome.com> Precedence: list MIME-Version: 1.0 To: =?utf-8?b?VG9tw6HFoSBCxb5hdGVr?= <tbzatek@redhat.com>, scanbot <jsafrane@redhat.com>, OpenLMI Developers <openlmi-reviews@lists.fedorahosted.org>, Radek Novacek <rnovacek@redhat.com> References: <20131202145835.234376.54734@ex-std-node147.prod.rhcloud.com> In-Reply-To: <20131202145835.234376.54734@ex-std-node147.prod.rhcloud.com> Date: Tue, 03 Dec 2013 12:33:36 -0000 Reply-To: =?utf-8?b?VG9tw6HFoSBCxb5hdGVr?= <tbzatek@redhat.com>, openlmi-reviews@lists.fedorahosted.org Message-ID: <20131203123336.6802.41827@ex-std-node147.prod.rhcloud.com> Content-Type: multipart/alternative; boundary="===============6695510937750119775==" Subject: Re: Review Request 1324: account: Initialize NULL the group array to prevent bad memory access Message: 63 --===============6695510937750119775== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1324/ ----------------------------------------------------------- (Updated Dec. 3, 2013, 12:33 p.m.) Status ------ This change has been marked as submitted. Review request for OpenLMI Developers. Repository: openlmi-providers Description ------- account: Initialize NULL the group array to prevent bad memory access Found by clang analysis: Error: PW.BRANCH_PAST_INITIALIZATION: openlmi-providers-0.4.1_75_gf47c906/src/account/LMI_AccountProvider.c:324: branch_past_initialization: transfer of control bypasses initialization of: openlmi-providers-0.4.1_75_gf47c906/src/account/LMI_AccountProvider.c:324: caretline: ^ openlmi-providers-0.4.1_75_gf47c906/src/account/LMI_AccountProvider.c:324: name_at_decl_position: variable "groups" (declared at line 328) Diffs ----- src/account/LMI_AccountProvider.c 35c870f6a5325c59999539e34e560ba625c6cbca Diff: http://reviewboard-openlmi.rhcloud.com/r/1324/diff/ Testing ------- Thanks, Tomáš Bžatek --===============6695510937750119775== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit <html> <body> <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;"> <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;"> <tr> <td> This is an automatically generated e-mail. To reply, visit: <a href="http://reviewboard-openlmi.rhcloud.com/r/1324/">http://reviewboard-openlmi.rhcloud.com/r/1324/</a> </td> </tr> </table> <br /> <table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray solid;"> <tr> <td> <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1> </td> </tr> </table> <br /> <table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://reviewboard-openlmi.rhcloud.com/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;"> <tr> <td> <div>Review request for OpenLMI Developers.</div> <div>By Tomáš Bžatek.</div> <p style="color: grey;"><i>Updated Dec. 3, 2013, 12:33 p.m.</i></p> <div style="margin-top: 1.5em;"> <b style="color: #575012; font-size: 10pt;">Repository: </b> openlmi-providers </div> <h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0"> <tr> <td> <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"> account: Initialize NULL the group array to prevent bad memory access Found by clang analysis: Error: PW.BRANCH_PAST_INITIALIZATION: openlmi-providers-0.4.1_75_gf47c906/src/account/LMI_AccountProvider.c:324: branch_past_initialization: transfer of control bypasses initialization of: openlmi-providers-0.4.1_75_gf47c906/src/account/LMI_AccountProvider.c:324: caretline: ^ openlmi-providers-0.4.1_75_gf47c906/src/account/LMI_AccountProvider.c:324: name_at_decl_position: variable &quot;groups&quot; (declared at line 328) </pre> </td> </tr> </table> <h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1> <ul style="margin-left: 3em; padding-left: 0;"> <li>src/account/LMI_AccountProvider.c <span style="color: grey">(35c870f6a5325c59999539e34e560ba625c6cbca)</span></li> </ul> <p><a href="http://reviewboard-openlmi.rhcloud.com/r/1324/diff/" style="margin-left: 3em;">View Diff</a></p> </td> </tr> </table> </div> </body> </html> --===============6695510937750119775==-- ]