[From nobody Mon Dec 2 11:53:43 2013 From: scanbot <reviewboard@gallagherhome.com> Precedence: list MIME-Version: 1.0 To: "scanbot" <jsafrane@redhat.com>, "OpenLMI Developers" <openlmi-reviews@lists.fedorahosted.org>, "Radek Novacek" <rnovacek@redhat.com> References: <20131202114402.234375.58998@ex-std-node147.prod.rhcloud.com> In-Reply-To: <20131202114402.234375.58998@ex-std-node147.prod.rhcloud.com> Date: Mon, 02 Dec 2013 11:50:26 -0000 Reply-To: scanbot <jsafrane@redhat.com>, openlmi-reviews@lists.fedorahosted.org Message-ID: <20131202115026.234376.50357@ex-std-node147.prod.rhcloud.com> Content-Type: multipart/alternative; boundary="===============3783094089132979827==" Subject: Re: Review Request 1317: networking [2/2] test: Increase timeout for applying the setting Message: 76 --===============3783094089132979827== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1317/#review1858 ----------------------------------------------------------- Autoscan started for review(s) 1316,1317 - scanbot On Dec. 2, 2013, 11:44 a.m., Radek Novacek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard-openlmi.rhcloud.com/r/1317/ > ----------------------------------------------------------- > > (Updated Dec. 2, 2013, 11:44 a.m.) > > > Review request for OpenLMI Developers. > > > Repository: openlmi-networking > > > Description > ------- > > test: Increase timeout for applying the setting > > This test timeouted sometimes because DHCP server didn't send response > soon enough (especially after the bridging test). > > It also adds a check for the correct indication not just any indication. > > > Diffs > ----- > > test/test_create_destroy_connection.py ae27991b229eb90d4e468bdbbbd8b8ea6875f0d7 > > Diff: http://reviewboard-openlmi.rhcloud.com/r/1317/diff/ > > > Testing > ------- > > > Thanks, > > Radek Novacek > > --===============3783094089132979827== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit <html> <body> <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;"> <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;"> <tr> <td> This is an automatically generated e-mail. To reply, visit: <a href="http://reviewboard-openlmi.rhcloud.com/r/1317/">http://reviewboard-openlmi.rhcloud.com/r/1317/</a> </td> </tr> </table> <br /> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Autoscan started for review(s) 1316,1317</pre> <br /> <p>- scanbot</p> <br /> <p>On December 2nd, 2013, 11:44 a.m. UTC, Radek Novacek wrote:</p> <table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://reviewboard-openlmi.rhcloud.com/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;"> <tr> <td> <div>Review request for OpenLMI Developers.</div> <div>By Radek Novacek.</div> <p style="color: grey;"><i>Updated Dec. 2, 2013, 11:44 a.m.</i></p> <div style="margin-top: 1.5em;"> <b style="color: #575012; font-size: 10pt;">Repository: </b> openlmi-networking </div> <h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0"> <tr> <td> <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">test: Increase timeout for applying the setting This test timeouted sometimes because DHCP server didn&#39;t send response soon enough (especially after the bridging test). It also adds a check for the correct indication not just any indication. </pre> </td> </tr> </table> <h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1> <ul style="margin-left: 3em; padding-left: 0;"> <li>test/test_create_destroy_connection.py <span style="color: grey">(ae27991b229eb90d4e468bdbbbd8b8ea6875f0d7)</span></li> </ul> <p><a href="http://reviewboard-openlmi.rhcloud.com/r/1317/diff/" style="margin-left: 3em;">View Diff</a></p> </td> </tr> </table> </div> </body> </html> --===============3783094089132979827==-- ]