[From nobody Wed Nov 20 12:00:17 2013 From: Tomas Smetana <reviewboard@gallagherhome.com> Precedence: list MIME-Version: 1.0 To: "Tomas Smetana" <tsmetana@redhat.com>, "OpenLMI Developers" <openlmi-reviews@lists.fedorahosted.org>, "Jan Safranek" <jsafrane@redhat.com> References: <20131118123736.234376.64626@ex-std-node147.prod.rhcloud.com> In-Reply-To: <20131118123736.234376.64626@ex-std-node147.prod.rhcloud.com> Date: Wed, 20 Nov 2013 09:20:08 -0000 Reply-To: Tomas Smetana <tsmetana@redhat.com>, openlmi-reviews@lists.fedorahosted.org Message-ID: <20131120092008.234376.60040@ex-std-node147.prod.rhcloud.com> Content-Type: multipart/alternative; boundary="===============6198637846668145645==" Subject: Re: Review Request 1252: Spec file: %ghost the openlmi-mof-register dynamically created files Message: 48 --===============6198637846668145645== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit > On Nov. 18, 2013, 1:37 p.m., Jan Safranek wrote: > > openlmi-providers.spec, line 411 > > <http://reviewboard-openlmi.rhcloud.com/r/1252/diff/1/?file=6610#file6610line411> > > > > shouldn't you create the files in %install first? What rpmbuild and rpmlint say? The directories and the sqlite file are being created by the script itself not the package and (theoretically) they don't have to exist in the system until something really uses the script, which is why I thouhgt %ghost is the proper solution. But you're right -- rpmlint doesn't like those ghosted files so I will create them during the installation and have them "hard-owned". - Tomas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1252/#review1713 ----------------------------------------------------------- On Nov. 20, 2013, 10:19 a.m., Tomas Smetana wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard-openlmi.rhcloud.com/r/1252/ > ----------------------------------------------------------- > > (Updated Nov. 20, 2013, 10:19 a.m.) > > > Review request for OpenLMI Developers. > > > Repository: openlmi-providers > > > Description > ------- > > This is the patch to ghost-own the directory structure in /var/lib created by the openlmi-mof-register script. This ensures the directories and the database get removed upon openlmi-providers package uninstall. > > > Diffs > ----- > > openlmi-providers.spec 549205ced754fc04aef50438ea8f8e8ebf7c638f > > Diff: http://reviewboard-openlmi.rhcloud.com/r/1252/diff/ > > > Testing > ------- > > > Thanks, > > Tomas Smetana > > --===============6198637846668145645== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit <html> <body> <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;"> <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;"> <tr> <td> This is an automatically generated e-mail. To reply, visit: <a href="http://reviewboard-openlmi.rhcloud.com/r/1252/">http://reviewboard-openlmi.rhcloud.com/r/1252/</a> </td> </tr> </table> <br /> <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;"> <p style="margin-top: 0;">On November 18th, 2013, 1:37 p.m. CET, <b>Jan Safranek</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;"> <table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;"> <thead> <tr> <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;"> <a href="http://reviewboard-openlmi.rhcloud.com/r/1252/diff/1/?file=6610#file6610line411" style="color: black; font-weight: bold; text-decoration: underline;">openlmi-providers.spec</a> <span style="font-weight: normal;"> (Diff revision 1) </span> </th> </tr> </thead> <tbody> <tr> <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">411</font></th> <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="k">%ghost</span> <span class="kp">%{_sharedstatedir}</span>/openlmi-registration</pre></td> </tr> </tbody> </table> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">shouldn&#39;t you create the files in %install first? What rpmbuild and rpmlint say?</pre> </blockquote> </blockquote> <pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The directories and the sqlite file are being created by the script itself not the package and (theoretically) they don&#39;t have to exist in the system until something really uses the script, which is why I thouhgt %ghost is the proper solution. But you&#39;re right -- rpmlint doesn&#39;t like those ghosted files so I will create them during the installation and have them &quot;hard-owned&quot;.</pre> <br /> <p>- Tomas</p> <br /> <p>On November 20th, 2013, 10:19 a.m. CET, Tomas Smetana wrote:</p> <table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://reviewboard-openlmi.rhcloud.com/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;"> <tr> <td> <div>Review request for OpenLMI Developers.</div> <div>By Tomas Smetana.</div> <p style="color: grey;"><i>Updated Nov. 20, 2013, 10:19 a.m.</i></p> <div style="margin-top: 1.5em;"> <b style="color: #575012; font-size: 10pt;">Repository: </b> openlmi-providers </div> <h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0"> <tr> <td> <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is the patch to ghost-own the directory structure in /var/lib created by the openlmi-mof-register script. This ensures the directories and the database get removed upon openlmi-providers package uninstall.</pre> </td> </tr> </table> <h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1> <ul style="margin-left: 3em; padding-left: 0;"> <li>openlmi-providers.spec <span style="color: grey">(549205ced754fc04aef50438ea8f8e8ebf7c638f)</span></li> </ul> <p><a href="http://reviewboard-openlmi.rhcloud.com/r/1252/diff/" style="margin-left: 3em;">View Diff</a></p> </td> </tr> </table> </div> </body> </html> --===============6198637846668145645==-- ]