[From nobody Thu Nov 14 12:00:13 2013 From: Michal Minar <reviewboard@gallagherhome.com> Precedence: list MIME-Version: 1.0 To: "Michal Minar" <miminar@redhat.com>, "Jan Safranek" <jsafrane@redhat.com>, "OpenLMI Developers" <openlmi-reviews@lists.fedorahosted.org> References: <20131113152314.234375.14148@ex-std-node147.prod.rhcloud.com> In-Reply-To: <20131113152314.234375.14148@ex-std-node147.prod.rhcloud.com> Date: Thu, 14 Nov 2013 09:09:48 -0000 Reply-To: Michal Minar <miminar@redhat.com>, openlmi-reviews@lists.fedorahosted.org Message-ID: <20131114090948.234376.60318@ex-std-node147.prod.rhcloud.com> Content-Type: multipart/alternative; boundary="===============3341305989642384463==" Subject: Re: Review Request 1242: logicalfile: don't assume 'Name' property is available before checking the class. Message: 19 --===============3341305989642384463== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1242/#review1695 ----------------------------------------------------------- Ship it! Ship It! - Michal Minar On Nov. 13, 2013, 3:23 p.m., Jan Safranek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard-openlmi.rhcloud.com/r/1242/ > ----------------------------------------------------------- > > (Updated Nov. 13, 2013, 3:23 p.m.) > > > Review request for OpenLMI Developers. > > > Repository: openlmi-providers > > > Description > ------- > > logicalfile: don't assume 'Name' property is available before checking the class. > > The provider must not crash when Associators and/or References is called > with odd object path - it does not need to be LMI_UnixDirectory or > CIM_LogicalFile. > > > Diffs > ----- > > src/logicalfile/LMI_DirectoryContainsFileProvider.c e1fd8c9bd9750a3e7f8589c3e3782dfc422ca3a6 > > Diff: http://reviewboard-openlmi.rhcloud.com/r/1242/diff/ > > > Testing > ------- > > > Thanks, > > Jan Safranek > > --===============3341305989642384463== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit <html> <body> <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;"> <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;"> <tr> <td> This is an automatically generated e-mail. To reply, visit: <a href="http://reviewboard-openlmi.rhcloud.com/r/1242/">http://reviewboard-openlmi.rhcloud.com/r/1242/</a> </td> </tr> </table> <br /> <p>Ship it!</p> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> <br /> <p>- Michal Minar</p> <br /> <p>On November 13th, 2013, 3:23 p.m. UTC, Jan Safranek wrote:</p> <table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://reviewboard-openlmi.rhcloud.com/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;"> <tr> <td> <div>Review request for OpenLMI Developers.</div> <div>By Jan Safranek.</div> <p style="color: grey;"><i>Updated Nov. 13, 2013, 3:23 p.m.</i></p> <div style="margin-top: 1.5em;"> <b style="color: #575012; font-size: 10pt;">Repository: </b> openlmi-providers </div> <h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0"> <tr> <td> <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">logicalfile: don&#39;t assume &#39;Name&#39; property is available before checking the class. The provider must not crash when Associators and/or References is called with odd object path - it does not need to be LMI_UnixDirectory or CIM_LogicalFile. </pre> </td> </tr> </table> <h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1> <ul style="margin-left: 3em; padding-left: 0;"> <li>src/logicalfile/LMI_DirectoryContainsFileProvider.c <span style="color: grey">(e1fd8c9bd9750a3e7f8589c3e3782dfc422ca3a6)</span></li> </ul> <p><a href="http://reviewboard-openlmi.rhcloud.com/r/1242/diff/" style="margin-left: 3em;">View Diff</a></p> </td> </tr> </table> </div> </body> </html> --===============3341305989642384463==-- ]