[From nobody Thu Oct 31 12:00:19 2013 From: Jan Safranek <reviewboard@gallagherhome.com> Precedence: list MIME-Version: 1.0 To: "OpenLMI Developers" <openlmi-reviews@lists.fedorahosted.org>, "Jan Safranek" <jsafrane@redhat.com>, "Radek Novacek" <rnovacek@redhat.com> References: <20131031110121.16930.13946@ex-std-node147.prod.rhcloud.com> In-Reply-To: <20131031110121.16930.13946@ex-std-node147.prod.rhcloud.com> Date: Thu, 31 Oct 2013 11:32:41 -0000 Reply-To: Jan Safranek <jsafrane@redhat.com>, openlmi-reviews@lists.fedorahosted.org Message-ID: <20131031113241.16931.36842@ex-std-node147.prod.rhcloud.com> Content-Type: multipart/alternative; boundary="===============4874237748420441167==" Subject: Re: Review Request 1153: providers [1/2] test: Don't test connection in the service provider Message: 39 --===============4874237748420441167== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1153/#review1574 ----------------------------------------------------------- Ship it! Ship It! - Jan Safranek On Oct. 31, 2013, 12:01 p.m., Radek Novacek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard-openlmi.rhcloud.com/r/1153/ > ----------------------------------------------------------- > > (Updated Oct. 31, 2013, 12:01 p.m.) > > > Review request for OpenLMI Developers. > > > Repository: openlmi-providers > > > Description > ------- > > test: Don't test connection in the service provider > > The test for creating socket and http connection get removed, because: > * socket connection might not work on the buildbot > * http(s) connection is tested in the service provider tests anyway > > > Diffs > ----- > > src/service-dbus/test/testService.py b3236378dcc30edcbd3e10eecd5c592a2ef3746e > > Diff: http://reviewboard-openlmi.rhcloud.com/r/1153/diff/ > > > Testing > ------- > > > Thanks, > > Radek Novacek > > --===============4874237748420441167== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit <html> <body> <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;"> <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;"> <tr> <td> This is an automatically generated e-mail. To reply, visit: <a href="http://reviewboard-openlmi.rhcloud.com/r/1153/">http://reviewboard-openlmi.rhcloud.com/r/1153/</a> </td> </tr> </table> <br /> <p>Ship it!</p> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> <br /> <p>- Jan Safranek</p> <br /> <p>On October 31st, 2013, 12:01 p.m. CET, Radek Novacek wrote:</p> <table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://reviewboard-openlmi.rhcloud.com/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;"> <tr> <td> <div>Review request for OpenLMI Developers.</div> <div>By Radek Novacek.</div> <p style="color: grey;"><i>Updated Oct. 31, 2013, 12:01 p.m.</i></p> <div style="margin-top: 1.5em;"> <b style="color: #575012; font-size: 10pt;">Repository: </b> openlmi-providers </div> <h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0"> <tr> <td> <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">test: Don&#39;t test connection in the service provider The test for creating socket and http connection get removed, because: * socket connection might not work on the buildbot * http(s) connection is tested in the service provider tests anyway </pre> </td> </tr> </table> <h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1> <ul style="margin-left: 3em; padding-left: 0;"> <li>src/service-dbus/test/testService.py <span style="color: grey">(b3236378dcc30edcbd3e10eecd5c592a2ef3746e)</span></li> </ul> <p><a href="http://reviewboard-openlmi.rhcloud.com/r/1153/diff/" style="margin-left: 3em;">View Diff</a></p> </td> </tr> </table> </div> </body> </html> --===============4874237748420441167==-- ]