[From nobody Tue Oct 29 12:00:09 2013 From: Radek Novacek <reviewboard@gallagherhome.com> Precedence: list MIME-Version: 1.0 To: =?utf-8?b?VG9tw6HFoSBCxb5hdGVr?= <tbzatek@redhat.com>, OpenLMI Developers <openlmi-reviews@lists.fedorahosted.org>, Radek Novacek <rnovacek@redhat.com> References: <20131025155052.6478.43599@ex-std-node147.prod.rhcloud.com> In-Reply-To: <20131025155052.6478.43599@ex-std-node147.prod.rhcloud.com> Date: Tue, 29 Oct 2013 07:35:57 -0000 Reply-To: Radek Novacek <rnovacek@redhat.com>, openlmi-reviews@lists.fedorahosted.org Message-ID: <20131029073557.16930.30854@ex-std-node147.prod.rhcloud.com> Content-Type: multipart/alternative; boundary="===============0279319414849056918==" Subject: Re: Review Request 1145: journald: Alter the MOF file for proper class parseout Message: 7 --===============0279319414849056918== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1145/#review1564 ----------------------------------------------------------- Ship it! Ship It! - Radek Novacek On Oct. 25, 2013, 5:50 p.m., Tomáš Bžatek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard-openlmi.rhcloud.com/r/1145/ > ----------------------------------------------------------- > > (Updated Oct. 25, 2013, 5:50 p.m.) > > > Review request for OpenLMI Developers. > > > Repository: openlmi-providers > > > Description > ------- > > journald: Alter the MOF file for proper class parseout > > With the recent change of the way classes are parsed out from MOF files > (commit 6d439c392595) the keyword "class" needs to be at the very beginning > of the line otherwise it gets ignored. > > -- > This fixes journald indication tests. > > > Diffs > ----- > > mof/60_LMI_Journald.mof 09d0578f583d02038fad399fa0e93b7900eca21e > > Diff: http://reviewboard-openlmi.rhcloud.com/r/1145/diff/ > > > Testing > ------- > > > Thanks, > > Tomáš Bžatek > > --===============0279319414849056918== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit <html> <body> <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;"> <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;"> <tr> <td> This is an automatically generated e-mail. To reply, visit: <a href="http://reviewboard-openlmi.rhcloud.com/r/1145/">http://reviewboard-openlmi.rhcloud.com/r/1145/</a> </td> </tr> </table> <br /> <p>Ship it!</p> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> <br /> <p>- Radek Novacek</p> <br /> <p>On October 25th, 2013, 5:50 p.m. CEST, Tomáš Bžatek wrote:</p> <table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://reviewboard-openlmi.rhcloud.com/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;"> <tr> <td> <div>Review request for OpenLMI Developers.</div> <div>By Tomáš Bžatek.</div> <p style="color: grey;"><i>Updated Oct. 25, 2013, 5:50 p.m.</i></p> <div style="margin-top: 1.5em;"> <b style="color: #575012; font-size: 10pt;">Repository: </b> openlmi-providers </div> <h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0"> <tr> <td> <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">journald: Alter the MOF file for proper class parseout With the recent change of the way classes are parsed out from MOF files (commit 6d439c392595) the keyword &quot;class&quot; needs to be at the very beginning of the line otherwise it gets ignored. -- This fixes journald indication tests. </pre> </td> </tr> </table> <h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1> <ul style="margin-left: 3em; padding-left: 0;"> <li>mof/60_LMI_Journald.mof <span style="color: grey">(09d0578f583d02038fad399fa0e93b7900eca21e)</span></li> </ul> <p><a href="http://reviewboard-openlmi.rhcloud.com/r/1145/diff/" style="margin-left: 3em;">View Diff</a></p> </td> </tr> </table> </div> </body> </html> --===============0279319414849056918==-- ]