[From nobody Fri Oct 25 12:00:15 2013 From: Jan Safranek <reviewboard@gallagherhome.com> Precedence: list MIME-Version: 1.0 To: =?utf-8?b?VG9tw6HFoSBCxb5hdGVr?= <tbzatek@redhat.com>, Jan Safranek <jsafrane@redhat.com>, OpenLMI Developers <openlmi-reviews@lists.fedorahosted.org> References: <20131025105448.6710.13950@ex-std-node147.prod.rhcloud.com> In-Reply-To: <20131025105448.6710.13950@ex-std-node147.prod.rhcloud.com> Date: Fri, 25 Oct 2013 11:34:04 -0000 Reply-To: Jan Safranek <jsafrane@redhat.com>, openlmi-reviews@lists.fedorahosted.org Message-ID: <20131025113404.6710.16878@ex-std-node147.prod.rhcloud.com> Content-Type: multipart/alternative; boundary="===============3298137795405785423==" Subject: Re: Review Request 1085: [1/2] journald: Tweak and cleanup the MOF file Message: 30 --===============3298137795405785423== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1085/#review1563 ----------------------------------------------------------- Ship it! Ship It! - Jan Safranek On Oct. 25, 2013, 12:54 p.m., Tomáš Bžatek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard-openlmi.rhcloud.com/r/1085/ > ----------------------------------------------------------- > > (Updated Oct. 25, 2013, 12:54 p.m.) > > > Review request for OpenLMI Developers. > > > Repository: openlmi-providers > > > Description > ------- > > journald: Tweak and cleanup the MOF file > > A bit of cleanup, adding "Implemented(true)" qualifiers where applicable, > adding forgotten properties used by the provider and also added and modified > description for the methods we implement. Note that only modified descriptions > have been added, the unchanged ones get inherited just fine. > > > Diffs > ----- > > mof/60_LMI_Journald.mof 27c2a3672b32388661ec38d03163bef9b5e31ab1 > src/journald/CMakeLists.txt 8e3b8b93212a21ef33ae7889fdddc0657012524f > > Diff: http://reviewboard-openlmi.rhcloud.com/r/1085/diff/ > > > Testing > ------- > > > Thanks, > > Tomáš Bžatek > > --===============3298137795405785423== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit <html> <body> <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;"> <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;"> <tr> <td> This is an automatically generated e-mail. To reply, visit: <a href="http://reviewboard-openlmi.rhcloud.com/r/1085/">http://reviewboard-openlmi.rhcloud.com/r/1085/</a> </td> </tr> </table> <br /> <p>Ship it!</p> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> <br /> <p>- Jan Safranek</p> <br /> <p>On October 25th, 2013, 12:54 p.m. CEST, Tomáš Bžatek wrote:</p> <table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://reviewboard-openlmi.rhcloud.com/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;"> <tr> <td> <div>Review request for OpenLMI Developers.</div> <div>By Tomáš Bžatek.</div> <p style="color: grey;"><i>Updated Oct. 25, 2013, 12:54 p.m.</i></p> <div style="margin-top: 1.5em;"> <b style="color: #575012; font-size: 10pt;">Repository: </b> openlmi-providers </div> <h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0"> <tr> <td> <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">journald: Tweak and cleanup the MOF file A bit of cleanup, adding &quot;Implemented(true)&quot; qualifiers where applicable, adding forgotten properties used by the provider and also added and modified description for the methods we implement. Note that only modified descriptions have been added, the unchanged ones get inherited just fine. </pre> </td> </tr> </table> <h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1> <ul style="margin-left: 3em; padding-left: 0;"> <li>mof/60_LMI_Journald.mof <span style="color: grey">(27c2a3672b32388661ec38d03163bef9b5e31ab1)</span></li> <li>src/journald/CMakeLists.txt <span style="color: grey">(8e3b8b93212a21ef33ae7889fdddc0657012524f)</span></li> </ul> <p><a href="http://reviewboard-openlmi.rhcloud.com/r/1085/diff/" style="margin-left: 3em;">View Diff</a></p> </td> </tr> </table> </div> </body> </html> --===============3298137795405785423==-- ]