[From nobody Wed Oct 23 12:00:15 2013 From: "=?utf-8?b?VG9tw6HFoSBCxb5hdGVr?=" <reviewboard@gallagherhome.com> Precedence: list MIME-Version: 1.0 To: =?utf-8?b?VG9tw6HFoSBCxb5hdGVr?= <tbzatek@redhat.com>, OpenLMI Developers <openlmi-reviews@lists.fedorahosted.org> Date: Tue, 22 Oct 2013 16:07:35 -0000 Reply-To: =?utf-8?b?VG9tw6HFoSBCxb5hdGVr?= <tbzatek@redhat.com>, openlmi-reviews@lists.fedorahosted.org Message-ID: <20131022160735.6710.66942@ex-std-node147.prod.rhcloud.com> Content-Type: multipart/alternative; boundary="===============0231401826653497637==" Subject: Review Request 1085: [1/2] journald: Tweak and cleanup the MOF file Message: 29 --===============0231401826653497637== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1085/ ----------------------------------------------------------- Review request for OpenLMI Developers. Repository: openlmi-providers Description ------- journald: Tweak and cleanup the MOF file A bit of cleanup, adding "Implemented(true)" qualifiers where applicable, adding forgotten properties used by the provider and also added and modified description for the methods we implement. Diffs ----- mof/60_LMI_Journald.mof 27c2a3672b32388661ec38d03163bef9b5e31ab1 src/journald/CMakeLists.txt 8e3b8b93212a21ef33ae7889fdddc0657012524f Diff: http://reviewboard-openlmi.rhcloud.com/r/1085/diff/ Testing ------- Thanks, Tomáš Bžatek --===============0231401826653497637== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit <html> <body> <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;"> <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;"> <tr> <td> This is an automatically generated e-mail. To reply, visit: <a href="http://reviewboard-openlmi.rhcloud.com/r/1085/">http://reviewboard-openlmi.rhcloud.com/r/1085/</a> </td> </tr> </table> <br /> <table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://reviewboard-openlmi.rhcloud.com/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;"> <tr> <td> <div>Review request for OpenLMI Developers.</div> <div>By Tomáš Bžatek.</div> <div style="margin-top: 1.5em;"> <b style="color: #575012; font-size: 10pt;">Repository: </b> openlmi-providers </div> <h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0"> <tr> <td> <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">journald: Tweak and cleanup the MOF file A bit of cleanup, adding &quot;Implemented(true)&quot; qualifiers where applicable, adding forgotten properties used by the provider and also added and modified description for the methods we implement. </pre> </td> </tr> </table> <h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1> <ul style="margin-left: 3em; padding-left: 0;"> <li>mof/60_LMI_Journald.mof <span style="color: grey">(27c2a3672b32388661ec38d03163bef9b5e31ab1)</span></li> <li>src/journald/CMakeLists.txt <span style="color: grey">(8e3b8b93212a21ef33ae7889fdddc0657012524f)</span></li> </ul> <p><a href="http://reviewboard-openlmi.rhcloud.com/r/1085/diff/" style="margin-left: 3em;">View Diff</a></p> </td> </tr> </table> </div> </body> </html> --===============0231401826653497637==-- ]