[From nobody Wed Oct 23 12:00:15 2013 From: Jan Safranek <reviewboard@gallagherhome.com> Precedence: list MIME-Version: 1.0 To: "Jan Safranek" <jsafrane@redhat.com>, "OpenLMI Developers" <openlmi-reviews@lists.fedorahosted.org> Date: Tue, 22 Oct 2013 15:04:59 -0000 Reply-To: Jan Safranek <jsafrane@redhat.com>, openlmi-reviews@lists.fedorahosted.org Message-ID: <20131022150459.6710.67473@ex-std-node147.prod.rhcloud.com> Content-Type: multipart/alternative; boundary="===============0534906043287338027==" Subject: Review Request 1081: openlmi-providers [1/4] service: fix test_restart_service_broker test, we must wait for the CIMOM to restart. Message: 24 --===============0534906043287338027== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1081/ ----------------------------------------------------------- Review request for OpenLMI Developers. Repository: openlmi-providers Description ------- service: fix test_restart_service_broker test, we must wait for the CIMOM to restart. The test expected that the CIMOM restarts atomically, which is not the case - there are few seconds of no CIM service and the test must wait until the CIMOM becomes online. Diffs ----- src/service-dbus/test/testService.py f509acc803f2292413e583318ed85f0fbfbcae9c Diff: http://reviewboard-openlmi.rhcloud.com/r/1081/diff/ Testing ------- Thanks, Jan Safranek --===============0534906043287338027== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit <html> <body> <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;"> <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;"> <tr> <td> This is an automatically generated e-mail. To reply, visit: <a href="http://reviewboard-openlmi.rhcloud.com/r/1081/">http://reviewboard-openlmi.rhcloud.com/r/1081/</a> </td> </tr> </table> <br /> <table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://reviewboard-openlmi.rhcloud.com/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;"> <tr> <td> <div>Review request for OpenLMI Developers.</div> <div>By Jan Safranek.</div> <div style="margin-top: 1.5em;"> <b style="color: #575012; font-size: 10pt;">Repository: </b> openlmi-providers </div> <h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0"> <tr> <td> <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">service: fix test_restart_service_broker test, we must wait for the CIMOM to restart. The test expected that the CIMOM restarts atomically, which is not the case - there are few seconds of no CIM service and the test must wait until the CIMOM becomes online.</pre> </td> </tr> </table> <h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1> <ul style="margin-left: 3em; padding-left: 0;"> <li>src/service-dbus/test/testService.py <span style="color: grey">(f509acc803f2292413e583318ed85f0fbfbcae9c)</span></li> </ul> <p><a href="http://reviewboard-openlmi.rhcloud.com/r/1081/diff/" style="margin-left: 3em;">View Diff</a></p> </td> </tr> </table> </div> </body> </html> --===============0534906043287338027==-- ]