[From nobody Thu Oct 17 07:32:19 2013 From: Radek Novacek <reviewboard@gallagherhome.com> Precedence: list MIME-Version: 1.0 To: "OpenLMI Developers" <openlmi-reviews@lists.fedorahosted.org>, "Jan Safranek" <jsafrane@redhat.com>, "Radek Novacek" <rnovacek@redhat.com> References: <20131016103008.25388.15716@ex-std-node147.prod.rhcloud.com> In-Reply-To: <20131016103008.25388.15716@ex-std-node147.prod.rhcloud.com> Date: Wed, 16 Oct 2013 13:11:51 -0000 Reply-To: Radek Novacek <rnovacek@redhat.com>, openlmi-reviews@lists.fedorahosted.org Message-ID: <20131016131151.25388.43779@ex-std-node147.prod.rhcloud.com> Content-Type: multipart/alternative; boundary="===============6087859563548311894==" Subject: Re: Review Request 1012: openlmi-storage: [3/7] Pass real device file name to blivet.crypto. Message: 4 --===============6087859563548311894== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1012/#review1436 ----------------------------------------------------------- Ship it! Ship It! - Radek Novacek On Oct. 16, 2013, 12:30 p.m., Jan Safranek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard-openlmi.rhcloud.com/r/1012/ > ----------------------------------------------------------- > > (Updated Oct. 16, 2013, 12:30 p.m.) > > > Review request for OpenLMI Developers. > > > Repository: openlmi-storage > > > Description > ------- > > Pass real device file name to blivet.crypto. > > Also check the device exists and has correct format. > > > Diffs > ----- > > src/lmi/storage/LMI_ExtentEncryptionConfigurationService.py be780a2efa5c6886312ff36be5f7de333e647e52 > > Diff: http://reviewboard-openlmi.rhcloud.com/r/1012/diff/ > > > Testing > ------- > > > Thanks, > > Jan Safranek > > --===============6087859563548311894== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit <html> <body> <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;"> <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;"> <tr> <td> This is an automatically generated e-mail. To reply, visit: <a href="http://reviewboard-openlmi.rhcloud.com/r/1012/">http://reviewboard-openlmi.rhcloud.com/r/1012/</a> </td> </tr> </table> <br /> <p>Ship it!</p> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> <br /> <p>- Radek Novacek</p> <br /> <p>On October 16th, 2013, 12:30 p.m. CEST, Jan Safranek wrote:</p> <table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://reviewboard-openlmi.rhcloud.com/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;"> <tr> <td> <div>Review request for OpenLMI Developers.</div> <div>By Jan Safranek.</div> <p style="color: grey;"><i>Updated Oct. 16, 2013, 12:30 p.m.</i></p> <div style="margin-top: 1.5em;"> <b style="color: #575012; font-size: 10pt;">Repository: </b> openlmi-storage </div> <h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0"> <tr> <td> <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Pass real device file name to blivet.crypto. Also check the device exists and has correct format.</pre> </td> </tr> </table> <h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1> <ul style="margin-left: 3em; padding-left: 0;"> <li>src/lmi/storage/LMI_ExtentEncryptionConfigurationService.py <span style="color: grey">(be780a2efa5c6886312ff36be5f7de333e647e52)</span></li> </ul> <p><a href="http://reviewboard-openlmi.rhcloud.com/r/1012/diff/" style="margin-left: 3em;">View Diff</a></p> </td> </tr> </table> </div> </body> </html> --===============6087859563548311894==-- ]