[From nobody Thu Oct 3 12:00:15 2013 From: Tomas Smetana <reviewboard@gallagherhome.com> Precedence: list MIME-Version: 1.0 To: "Tomas Smetana" <tsmetana@redhat.com>, "Jan Synacek" <jsynacek@redhat.com>, "OpenLMI Developers" <openlmi-reviews@lists.fedorahosted.org>, "Radek Novacek" <rnovacek@redhat.com> References: <20131002104341.20614.26989@ex-std-node147.prod.rhcloud.com> In-Reply-To: <20131002104341.20614.26989@ex-std-node147.prod.rhcloud.com> Date: Thu, 03 Oct 2013 08:41:30 -0000 Reply-To: Tomas Smetana <tsmetana@redhat.com>, openlmi-reviews@lists.fedorahosted.org Message-ID: <20131003084130.20615.97348@ex-std-node147.prod.rhcloud.com> Content-Type: multipart/alternative; boundary="===============5934515767864345729==" Subject: Re: Review Request 915: Fixes and improvements to the new registration script Message: 31 --===============5934515767864345729== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/915/ ----------------------------------------------------------- (Updated Oct. 3, 2013, 10:41 a.m.) Status ------ This change has been marked as submitted. Review request for OpenLMI Developers. Repository: openlmi-providers Description ------- This is an aggregate patch (sorry) of several issues I have discovered in the new registration script: - Print usage when invoked with no arguments - Fix SQL parameters bindings: use tuples properly - Fix querying of registrations with no REG file - Log the "main" action before it's actually performed for better logs readability Diffs ----- openlmi-mof-register.py bac1e2393e09826983f32bade4f45cc342290e00 Diff: http://reviewboard-openlmi.rhcloud.com/r/915/diff/ Testing ------- Thanks, Tomas Smetana --===============5934515767864345729== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit <html> <body> <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;"> <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;"> <tr> <td> This is an automatically generated e-mail. To reply, visit: <a href="http://reviewboard-openlmi.rhcloud.com/r/915/">http://reviewboard-openlmi.rhcloud.com/r/915/</a> </td> </tr> </table> <br /> <table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray solid;"> <tr> <td> <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1> </td> </tr> </table> <br /> <table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://reviewboard-openlmi.rhcloud.com/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;"> <tr> <td> <div>Review request for OpenLMI Developers.</div> <div>By Tomas Smetana.</div> <p style="color: grey;"><i>Updated Oct. 3, 2013, 10:41 a.m.</i></p> <div style="margin-top: 1.5em;"> <b style="color: #575012; font-size: 10pt;">Repository: </b> openlmi-providers </div> <h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0"> <tr> <td> <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is an aggregate patch (sorry) of several issues I have discovered in the new registration script: - Print usage when invoked with no arguments - Fix SQL parameters bindings: use tuples properly - Fix querying of registrations with no REG file - Log the &quot;main&quot; action before it&#39;s actually performed for better logs readability</pre> </td> </tr> </table> <h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1> <ul style="margin-left: 3em; padding-left: 0;"> <li>openlmi-mof-register.py <span style="color: grey">(bac1e2393e09826983f32bade4f45cc342290e00)</span></li> </ul> <p><a href="http://reviewboard-openlmi.rhcloud.com/r/915/diff/" style="margin-left: 3em;">View Diff</a></p> </td> </tr> </table> </div> </body> </html> --===============5934515767864345729==-- ]