[From nobody Wed Oct 2 12:00:19 2013 From: Jan Synacek <reviewboard@gallagherhome.com> Precedence: list MIME-Version: 1.0 To: "Tomas Smetana" <tsmetana@redhat.com>, "Jan Synacek" <jsynacek@redhat.com>, "OpenLMI Developers" <openlmi-reviews@lists.fedorahosted.org> References: <20131002104341.20614.26989@ex-std-node147.prod.rhcloud.com> In-Reply-To: <20131002104341.20614.26989@ex-std-node147.prod.rhcloud.com> Date: Wed, 02 Oct 2013 10:53:09 -0000 Reply-To: Jan Synacek <jsynacek@redhat.com>, openlmi-reviews@lists.fedorahosted.org Message-ID: <20131002105309.20614.82729@ex-std-node147.prod.rhcloud.com> Content-Type: multipart/alternative; boundary="===============3915045307672308090==" Subject: Re: Review Request 915: Fixes and improvements to the new registration script Message: 53 --===============3915045307672308090== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/915/#review1278 ----------------------------------------------------------- Ship it! Cosmetics. Ship it! openlmi-mof-register.py <http://reviewboard-openlmi.rhcloud.com/r/915/#comment801> I'd replace apostrophes with double quotes for consistency. openlmi-mof-register.py <http://reviewboard-openlmi.rhcloud.com/r/915/#comment802> I'd replace apostrophes with double quotes for consistency. openlmi-mof-register.py <http://reviewboard-openlmi.rhcloud.com/r/915/#comment803> I'd replace apostrophes with double quotes for consistency. - Jan Synacek On Oct. 2, 2013, 12:43 p.m., Tomas Smetana wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard-openlmi.rhcloud.com/r/915/ > ----------------------------------------------------------- > > (Updated Oct. 2, 2013, 12:43 p.m.) > > > Review request for OpenLMI Developers. > > > Repository: openlmi-providers > > > Description > ------- > > This is an aggregate patch (sorry) of several issues I have discovered in the new registration script: > > - Print usage when invoked with no arguments > - Fix SQL parameters bindings: use tuples properly > - Fix querying of registrations with no REG file > - Log the "main" action before it's actually performed for better logs readability > > > Diffs > ----- > > openlmi-mof-register.py bac1e2393e09826983f32bade4f45cc342290e00 > > Diff: http://reviewboard-openlmi.rhcloud.com/r/915/diff/ > > > Testing > ------- > > > Thanks, > > Tomas Smetana > > --===============3915045307672308090== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit <html> <body> <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;"> <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;"> <tr> <td> This is an automatically generated e-mail. To reply, visit: <a href="http://reviewboard-openlmi.rhcloud.com/r/915/">http://reviewboard-openlmi.rhcloud.com/r/915/</a> </td> </tr> </table> <br /> <p>Ship it!</p> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Cosmetics. Ship it!</pre> <br /> <div> <table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;"> <thead> <tr> <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;"> <a href="http://reviewboard-openlmi.rhcloud.com/r/915/diff/1/?file=5057#file5057line535" style="color: black; font-weight: bold; text-decoration: underline;">openlmi-mof-register.py</a> <span style="font-weight: normal;"> (Diff revision 1) </span> </th> </tr> </thead> <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;"> <tr> <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">def list_db():</pre></td> </tr> </tbody> <tbody> <tr> <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">535</font></th> <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">log_msg</span><span class="p">(</span><span class="s">&#39;Registering mofs: &#39;</span> <span class="o">+</span> <span class="s">&quot; &quot;</span><span class="o">.</span><span class="n">join</span><span class="p">(</span><span class="n">mofs</span><span class="p">)</span> <span class="o">+</span> <span class="s">&quot;, reg: &quot;</span> <span class="o">+</span> <span class="nb">str</span><span class="p">(</span><span class="n">reg</span><span class="p">))</span></pre></td> </tr> </tbody> </table> <pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I&#39;d replace apostrophes with double quotes for consistency.</pre> </div> <br /> <div> <table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;"> <thead> <tr> <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;"> <a href="http://reviewboard-openlmi.rhcloud.com/r/915/diff/1/?file=5057#file5057line539" style="color: black; font-weight: bold; text-decoration: underline;">openlmi-mof-register.py</a> <span style="font-weight: normal;"> (Diff revision 1) </span> </th> </tr> </thead> <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;"> <tr> <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">def list_db():</pre></td> </tr> </tbody> <tbody> <tr> <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">539</font></th> <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">log_msg</span><span class="p">(</span><span class="s">&#39;Unregistering mofs: &#39;</span> <span class="o">+</span> <span class="s">&quot; &quot;</span><span class="o">.</span><span class="n">join</span><span class="p">(</span><span class="n">mofs</span><span class="p">)</span> <span class="o">+</span> <span class="s">&quot;, reg: &quot;</span> <span class="o">+</span> <span class="nb">str</span><span class="p">(</span><span class="n">reg</span><span class="p">))</span></pre></td> </tr> </tbody> </table> <pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I&#39;d replace apostrophes with double quotes for consistency.</pre> </div> <br /> <div> <table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;"> <thead> <tr> <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;"> <a href="http://reviewboard-openlmi.rhcloud.com/r/915/diff/1/?file=5057#file5057line543" style="color: black; font-weight: bold; text-decoration: underline;">openlmi-mof-register.py</a> <span style="font-weight: normal;"> (Diff revision 1) </span> </th> </tr> </thead> <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;"> <tr> <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">def list_db():</pre></td> </tr> </tbody> <tbody> <tr> <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">543</font></th> <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">log_msg</span><span class="p">(</span><span class="s">&#39;Re-registering mofs: &#39;</span> <span class="o">+</span> <span class="s">&quot; &quot;</span><span class="o">.</span><span class="n">join</span><span class="p">(</span><span class="n">mofs</span><span class="p">)</span> <span class="o">+</span> <span class="s">&quot;, reg: &quot;</span> <span class="o">+</span> <span class="nb">str</span><span class="p">(</span><span class="n">reg</span><span class="p">))</span></pre></td> </tr> </tbody> </table> <pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I&#39;d replace apostrophes with double quotes for consistency.</pre> </div> <br /> <p>- Jan Synacek</p> <br /> <p>On October 2nd, 2013, 12:43 p.m. CEST, Tomas Smetana wrote:</p> <table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://reviewboard-openlmi.rhcloud.com/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;"> <tr> <td> <div>Review request for OpenLMI Developers.</div> <div>By Tomas Smetana.</div> <p style="color: grey;"><i>Updated Oct. 2, 2013, 12:43 p.m.</i></p> <div style="margin-top: 1.5em;"> <b style="color: #575012; font-size: 10pt;">Repository: </b> openlmi-providers </div> <h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0"> <tr> <td> <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is an aggregate patch (sorry) of several issues I have discovered in the new registration script: - Print usage when invoked with no arguments - Fix SQL parameters bindings: use tuples properly - Fix querying of registrations with no REG file - Log the &quot;main&quot; action before it&#39;s actually performed for better logs readability</pre> </td> </tr> </table> <h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1> <ul style="margin-left: 3em; padding-left: 0;"> <li>openlmi-mof-register.py <span style="color: grey">(bac1e2393e09826983f32bade4f45cc342290e00)</span></li> </ul> <p><a href="http://reviewboard-openlmi.rhcloud.com/r/915/diff/" style="margin-left: 3em;">View Diff</a></p> </td> </tr> </table> </div> </body> </html> --===============3915045307672308090==-- ]