[From nobody Thu Sep 26 12:00:15 2013 From: Michal Minar <reviewboard@gallagherhome.com> Precedence: list MIME-Version: 1.0 To: "Michal Minar" <miminar@redhat.com>, "Peter Schiffer" <pschiffe@redhat.com>, "OpenLMI Developers" <openlmi-reviews@lists.fedorahosted.org> References: <20130924135850.20614.30986@ex-std-node147.prod.rhcloud.com> In-Reply-To: <20130924135850.20614.30986@ex-std-node147.prod.rhcloud.com> Date: Wed, 25 Sep 2013 12:09:04 -0000 Reply-To: Michal Minar <miminar@redhat.com>, openlmi-reviews@lists.fedorahosted.org Message-ID: <20130925120904.20614.32041@ex-std-node147.prod.rhcloud.com> Content-Type: multipart/alternative; boundary="===============5931066752499846984==" Subject: Re: Review Request 849: Hardware: Move PCI bus initialization to the Initialize() function Message: 1 --===============5931066752499846984== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/849/#review1227 ----------------------------------------------------------- Ship it! Ship It! - Michal Minar On Sept. 24, 2013, 1:58 p.m., Peter Schiffer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard-openlmi.rhcloud.com/r/849/ > ----------------------------------------------------------- > > (Updated Sept. 24, 2013, 1:58 p.m.) > > > Review request for OpenLMI Developers. > > > Repository: openlmi-providers > > > Description > ------- > > Hardware: Move PCI bus initialization to the Initialize() function > > Move initialize and cleanup code to the Initialize() and Cleanup() functions. > > > Diffs > ----- > > src/hardware/LMI_PCIBridgeProvider.c 33927728a856314cc2ad7b7df1222334fb15841a > src/hardware/LMI_PCIBridgeSystemDeviceProvider.c 2151dd56a63240503ef966d198702d41dc3954c9 > src/hardware/LMI_PCIDeviceProvider.c cc6adc815c4ced422fc17c8fa8080039d9096eaf > src/hardware/LMI_PCIDeviceSystemDeviceProvider.c 897f7bcad840512c82dacc95cba81c9728942990 > src/hardware/PCIDev.h 7e4cf0d96cc50a962f7c136ea72d336f77ceaa78 > src/hardware/PCIDev.c 40051b30bc59dba7f3b488fdc92e05c51e2cbe82 > > Diff: http://reviewboard-openlmi.rhcloud.com/r/849/diff/ > > > Testing > ------- > > > Thanks, > > Peter Schiffer > > --===============5931066752499846984== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit <html> <body> <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;"> <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;"> <tr> <td> This is an automatically generated e-mail. To reply, visit: <a href="http://reviewboard-openlmi.rhcloud.com/r/849/">http://reviewboard-openlmi.rhcloud.com/r/849/</a> </td> </tr> </table> <br /> <p>Ship it!</p> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> <br /> <p>- Michal Minar</p> <br /> <p>On September 24th, 2013, 1:58 p.m. UTC, Peter Schiffer wrote:</p> <table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://reviewboard-openlmi.rhcloud.com/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;"> <tr> <td> <div>Review request for OpenLMI Developers.</div> <div>By Peter Schiffer.</div> <p style="color: grey;"><i>Updated Sept. 24, 2013, 1:58 p.m.</i></p> <div style="margin-top: 1.5em;"> <b style="color: #575012; font-size: 10pt;">Repository: </b> openlmi-providers </div> <h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0"> <tr> <td> <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hardware: Move PCI bus initialization to the Initialize() function Move initialize and cleanup code to the Initialize() and Cleanup() functions.</pre> </td> </tr> </table> <h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1> <ul style="margin-left: 3em; padding-left: 0;"> <li>src/hardware/LMI_PCIBridgeProvider.c <span style="color: grey">(33927728a856314cc2ad7b7df1222334fb15841a)</span></li> <li>src/hardware/LMI_PCIBridgeSystemDeviceProvider.c <span style="color: grey">(2151dd56a63240503ef966d198702d41dc3954c9)</span></li> <li>src/hardware/LMI_PCIDeviceProvider.c <span style="color: grey">(cc6adc815c4ced422fc17c8fa8080039d9096eaf)</span></li> <li>src/hardware/LMI_PCIDeviceSystemDeviceProvider.c <span style="color: grey">(897f7bcad840512c82dacc95cba81c9728942990)</span></li> <li>src/hardware/PCIDev.h <span style="color: grey">(7e4cf0d96cc50a962f7c136ea72d336f77ceaa78)</span></li> <li>src/hardware/PCIDev.c <span style="color: grey">(40051b30bc59dba7f3b488fdc92e05c51e2cbe82)</span></li> </ul> <p><a href="http://reviewboard-openlmi.rhcloud.com/r/849/diff/" style="margin-left: 3em;">View Diff</a></p> </td> </tr> </table> </div> </body> </html> --===============5931066752499846984==-- ]