<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://reviewboard-openlmi.rhcloud.com/r/873/">http://reviewboard-openlmi.rhcloud.com/r/873/</a>
     </td>
    </tr>
   </table>
   <br />










<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
 <p style="margin-top: 0;">On September 18th, 2013, 2:30 p.m. CEST, <b>Michal Minar</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
  



<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
 <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
    <a href="http://reviewboard-openlmi.rhcloud.com/r/873/diff/1/?file=4914#file4914line94" style="color: black; font-weight: bold; text-decoration: underline;">src/logicalfile/file.h</a>
    <span style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>



 
 

 <tbody>

  <tr>
    <th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">85</font></th>
    <td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cp">    LMI_##cmpitype##_Set_CreationClassName(&amp;lmi_file, aux);                   \</span></pre></td>
    <th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">94</font></th>
    <td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cp">#define check_status(st)                                                      \</span></pre></td>
  </tr>

 </tbody>

</table>

  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This might be beneficial to the others too. What about placing it in openlmi.h or perhaps openlmi_macros.h :)?

This applies also to check_class_check_status(), return_with_status() and maybe others.</pre>
 </blockquote>





</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Good idea, I&#39;ll move those into openlmi.h as a separate commit. </pre>
<br />




<p>- Jan</p>


<br />
<p>On September 18th, 2013, 12:42 p.m. CEST, Jan Synacek wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://reviewboard-openlmi.rhcloud.com/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for OpenLMI Developers.</div>
<div>By Jan Synacek.</div>


<p style="color: grey;"><i>Updated Sept. 18, 2013, 12:42 p.m.</i></p>









<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
openlmi-providers
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">logicalfile: code cleanup and rewrite

GetInstance() calls were rewritten using cleaner code. Also, the macros
that were used before were either rewritten to functions, or cleaned up
so they wouldn&#39;t return or do anything unexpected.

Helper functions now use CMPIStatus more consistently.

Some memory leaks were fixed.
</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">All upstream tests finish successfully. Additional testing done using the openlmi scripts.</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/logicalfile/LMI_DataFileProvider.c <span style="color: grey">(ea410c3e40aaf6a728e489250c681d85ecf7713f)</span></li>

 <li>src/logicalfile/LMI_DirectoryContainsFileProvider.c <span style="color: grey">(427c2a635dc76fe6dddebc71a3e4d28f3e11c2cd)</span></li>

 <li>src/logicalfile/LMI_FIFOPipeFileProvider.c <span style="color: grey">(8730299be3f380bc17942c7109c86dcc6e25f7dd)</span></li>

 <li>src/logicalfile/LMI_FileIdentityProvider.c <span style="color: grey">(7720a751447f17cf103e82e2507a893d09a448af)</span></li>

 <li>src/logicalfile/LMI_RootDirectoryProvider.c <span style="color: grey">(0c3b23ea14d02c0e26644d9069cc846dc66eebf7)</span></li>

 <li>src/logicalfile/LMI_SymbolicLinkProvider.c <span style="color: grey">(c93c087a8ad1c804d2f2e5381a35a6e6ec7c9567)</span></li>

 <li>src/logicalfile/LMI_UnixDeviceFileProvider.c <span style="color: grey">(4d09efa6b134693cbbd97cb4f636dfccfa7d115d)</span></li>

 <li>src/logicalfile/LMI_UnixDirectoryProvider.c <span style="color: grey">(bdd12454f9dba30294f9f79b1c5db95499b4732e)</span></li>

 <li>src/logicalfile/LMI_UnixFileProvider.c <span style="color: grey">(6b3a45e85b3baff87f7cc95d74fe76d42be3ab40)</span></li>

 <li>src/logicalfile/LMI_UnixSocketProvider.c <span style="color: grey">(56fb6bdba2dbca08486ca93a566ab3e390031185)</span></li>

 <li>src/logicalfile/file.h <span style="color: grey">(938673c0174edb8948b165914472e7bdf3cffcdf)</span></li>

 <li>src/logicalfile/file.c <span style="color: grey">(e768ea0b67a264d124f3f93fbcb9a43b687b86d2)</span></li>

</ul>

<p><a href="http://reviewboard-openlmi.rhcloud.com/r/873/diff/" style="margin-left: 3em;">View Diff</a></p>







  </td>
 </tr>
</table>








  </div>
 </body>
</html>