[From nobody Tue Sep 3 12:00:18 2013 From: Radek Novacek <reviewboard@gallagherhome.com> Precedence: list MIME-Version: 1.0 To: "Tomas Smetana" <tsmetana@redhat.com>, "OpenLMI Developers" <openlmi-reviews@lists.fedorahosted.org>, "Radek Novacek" <rnovacek@redhat.com> References: <20130902123922.23096.45488@ex-std-node147.prod.rhcloud.com> In-Reply-To: <20130902123922.23096.45488@ex-std-node147.prod.rhcloud.com> Date: Mon, 02 Sep 2013 12:43:34 -0000 Reply-To: Radek Novacek <rnovacek@redhat.com>, openlmi-reviews@lists.fedorahosted.org Message-ID: <20130902124334.23097.50317@ex-std-node147.prod.rhcloud.com> Content-Type: multipart/alternative; boundary="===============0471599302390076400==" Subject: Re: Review Request 807: openlmi-mof-register.py: Fix the registration timestamp formatting Message: 3 --===============0471599302390076400== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/807/#review1061 ----------------------------------------------------------- Ship it! Ship It! - Radek Novacek On Sept. 2, 2013, 2:39 p.m., Tomas Smetana wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard-openlmi.rhcloud.com/r/807/ > ----------------------------------------------------------- > > (Updated Sept. 2, 2013, 2:39 p.m.) > > > Review request for OpenLMI Developers. > > > Repository: openlmi-providers > > > Description > ------- > > The strftime formatting string used in the INSERT statement for the registrations table is wrong: %f is superset of %S so I stored the seconds twice. > > > Diffs > ----- > > openlmi-mof-register.py cc0ab52cbba1b73de1724ec92a0118369c09cc07 > > Diff: http://reviewboard-openlmi.rhcloud.com/r/807/diff/ > > > Testing > ------- > > > Thanks, > > Tomas Smetana > > --===============0471599302390076400== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit <html> <body> <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;"> <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;"> <tr> <td> This is an automatically generated e-mail. To reply, visit: <a href="http://reviewboard-openlmi.rhcloud.com/r/807/">http://reviewboard-openlmi.rhcloud.com/r/807/</a> </td> </tr> </table> <br /> <p>Ship it!</p> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> <br /> <p>- Radek Novacek</p> <br /> <p>On September 2nd, 2013, 2:39 p.m. CEST, Tomas Smetana wrote:</p> <table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://reviewboard-openlmi.rhcloud.com/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;"> <tr> <td> <div>Review request for OpenLMI Developers.</div> <div>By Tomas Smetana.</div> <p style="color: grey;"><i>Updated Sept. 2, 2013, 2:39 p.m.</i></p> <div style="margin-top: 1.5em;"> <b style="color: #575012; font-size: 10pt;">Repository: </b> openlmi-providers </div> <h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0"> <tr> <td> <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The strftime formatting string used in the INSERT statement for the registrations table is wrong: %f is superset of %S so I stored the seconds twice.</pre> </td> </tr> </table> <h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1> <ul style="margin-left: 3em; padding-left: 0;"> <li>openlmi-mof-register.py <span style="color: grey">(cc0ab52cbba1b73de1724ec92a0118369c09cc07)</span></li> </ul> <p><a href="http://reviewboard-openlmi.rhcloud.com/r/807/diff/" style="margin-left: 3em;">View Diff</a></p> </td> </tr> </table> </div> </body> </html> --===============0471599302390076400==-- ]