[From nobody Fri Aug 2 12:00:13 2013 From: Roman Rakus <reviewboard@gallagherhome.com> Precedence: list MIME-Version: 1.0 To: "Radek Novacek" <rnovacek@redhat.com>, "OpenLMI Developers" <openlmi-reviews@lists.fedorahosted.org>, "Roman Rakus" <rrakus@redhat.com> References: <20130801143704.714.38355@ex-std-node147.prod.rhcloud.com> In-Reply-To: <20130801143704.714.38355@ex-std-node147.prod.rhcloud.com> Date: Thu, 01 Aug 2013 15:10:42 -0000 Reply-To: Roman Rakus <rrakus@redhat.com>, openlmi-reviews@lists.fedorahosted.org Message-ID: <20130801151042.713.89347@ex-std-node147.prod.rhcloud.com> Content-Type: multipart/alternative; boundary="===============1703609775591898031==" Subject: Re: Review Request 670: openlmi-providers [1/1] Add logging to the openlmi-mof-register script Message: 7 --===============1703609775591898031== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/670/#review849 ----------------------------------------------------------- Ship it! Let's go with this. I will play with another solution using set -x, setting PS4='\t'. I also have to figure how to store return values. - Roman Rakus On Aug. 1, 2013, 2:37 p.m., Radek Novacek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard-openlmi.rhcloud.com/r/670/ > ----------------------------------------------------------- > > (Updated Aug. 1, 2013, 2:37 p.m.) > > > Review request for OpenLMI Developers. > > > Repository: openlmi-providers > > > Description > ------- > > Add logging to the openlmi-mof-register script > > Each command in the registration script is now logged into > /var/log/openlmi-install.log file. > > > Diffs > ----- > > openlmi-mof-register 4e60e31786e22b063e4c3a42116e05038f5275c3 > openlmi-providers.spec 0552a8cc01c8c3979a2304463f0a663fcc993a95 > > Diff: http://reviewboard-openlmi.rhcloud.com/r/670/diff/ > > > Testing > ------- > > > Thanks, > > Radek Novacek > > --===============1703609775591898031== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit <html> <body> <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;"> <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;"> <tr> <td> This is an automatically generated e-mail. To reply, visit: <a href="http://reviewboard-openlmi.rhcloud.com/r/670/">http://reviewboard-openlmi.rhcloud.com/r/670/</a> </td> </tr> </table> <br /> <p>Ship it!</p> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Let&#39;s go with this. I will play with another solution using set -x, setting PS4=&#39;\t&#39;. I also have to figure how to store return values.</pre> <br /> <p>- Roman Rakus</p> <br /> <p>On August 1st, 2013, 2:37 p.m. UTC, Radek Novacek wrote:</p> <table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://reviewboard-openlmi.rhcloud.com/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;"> <tr> <td> <div>Review request for OpenLMI Developers.</div> <div>By Radek Novacek.</div> <p style="color: grey;"><i>Updated Aug. 1, 2013, 2:37 p.m.</i></p> <div style="margin-top: 1.5em;"> <b style="color: #575012; font-size: 10pt;">Repository: </b> openlmi-providers </div> <h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0"> <tr> <td> <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Add logging to the openlmi-mof-register script Each command in the registration script is now logged into /var/log/openlmi-install.log file. </pre> </td> </tr> </table> <h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1> <ul style="margin-left: 3em; padding-left: 0;"> <li>openlmi-mof-register <span style="color: grey">(4e60e31786e22b063e4c3a42116e05038f5275c3)</span></li> <li>openlmi-providers.spec <span style="color: grey">(0552a8cc01c8c3979a2304463f0a663fcc993a95)</span></li> </ul> <p><a href="http://reviewboard-openlmi.rhcloud.com/r/670/diff/" style="margin-left: 3em;">View Diff</a></p> </td> </tr> </table> </div> </body> </html> --===============1703609775591898031==-- ]