[From nobody Tue Jul 30 12:00:20 2013 From: Peter Schiffer <reviewboard@gallagherhome.com> Precedence: list MIME-Version: 1.0 To: "Peter Schiffer" <pschiffe@redhat.com>, "OpenLMI Developers" <openlmi-reviews@lists.fedorahosted.org>, "Jan Safranek" <jsafrane@redhat.com> References: <20130729125848.713.22181@ex-std-node147.prod.rhcloud.com> In-Reply-To: <20130729125848.713.22181@ex-std-node147.prod.rhcloud.com> Date: Mon, 29 Jul 2013 13:53:36 -0000 Reply-To: Peter Schiffer <pschiffe@redhat.com>, openlmi-reviews@lists.fedorahosted.org Message-ID: <20130729135336.713.34258@ex-std-node147.prod.rhcloud.com> Content-Type: multipart/alternative; boundary="===============3985178097948602485==" Subject: Re: Review Request 644: Hardware: Added additional information to the LMI_Chassis Message: 8 --===============3985178097948602485== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/644/ ----------------------------------------------------------- (Updated July 29, 2013, 3:53 p.m.) Status ------ This change has been marked as submitted. Review request for OpenLMI Developers. Repository: openlmi-providers Description ------- Hardware: Added additional information to the LMI_Chassis Added information about tag, model, product name and UUID to the LMI_Chassis. Diffs ----- mof/60_LMI_Hardware.mof 2b07f367954f26bf1250f06275baa121e2a2cb41 src/hardware/LMI_BaseboardContainerProvider.c 15e58a5b555a15312a88d8b8bcfa25ed924a5777 src/hardware/LMI_ChassisComputerSystemPackageProvider.c d0fc0043c9ef0b968d77bef71178aff8f9f06542 src/hardware/LMI_ChassisProvider.c 2ef7342be0a0bab8ff7a9bf080df11be701469e1 src/hardware/LMI_PhysicalBatteryContainerProvider.c 46bcad489c0873c6b383d8eb75d093cdba7e665d src/hardware/LMI_PortPhysicalConnectorContainerProvider.c 85fb16dc57411e799ed21302f743a0c8f0d802f1 src/hardware/LMI_ProcessorChipContainerProvider.c 49a9bae14c7871f048dd4fa9e7833e38ace9cab2 src/hardware/LMI_SystemSlotContainerProvider.c c752fbea5ca6f606b84a3f4a613e887aab0f3215 src/hardware/dmidecode.h a29d90d8835da2b81d5d1e95fa38dd31c97b559f src/hardware/dmidecode.c a171707f40c0b95465c620a5ea6f5e46a5699e35 Diff: http://reviewboard-openlmi.rhcloud.com/r/644/diff/ Testing ------- Thanks, Peter Schiffer --===============3985178097948602485== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit <html> <body> <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;"> <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;"> <tr> <td> This is an automatically generated e-mail. To reply, visit: <a href="http://reviewboard-openlmi.rhcloud.com/r/644/">http://reviewboard-openlmi.rhcloud.com/r/644/</a> </td> </tr> </table> <br /> <table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray solid;"> <tr> <td> <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1> </td> </tr> </table> <br /> <table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://reviewboard-openlmi.rhcloud.com/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;"> <tr> <td> <div>Review request for OpenLMI Developers.</div> <div>By Peter Schiffer.</div> <p style="color: grey;"><i>Updated July 29, 2013, 3:53 p.m.</i></p> <div style="margin-top: 1.5em;"> <b style="color: #575012; font-size: 10pt;">Repository: </b> openlmi-providers </div> <h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0"> <tr> <td> <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hardware: Added additional information to the LMI_Chassis Added information about tag, model, product name and UUID to the LMI_Chassis.</pre> </td> </tr> </table> <h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1> <ul style="margin-left: 3em; padding-left: 0;"> <li>mof/60_LMI_Hardware.mof <span style="color: grey">(2b07f367954f26bf1250f06275baa121e2a2cb41)</span></li> <li>src/hardware/LMI_BaseboardContainerProvider.c <span style="color: grey">(15e58a5b555a15312a88d8b8bcfa25ed924a5777)</span></li> <li>src/hardware/LMI_ChassisComputerSystemPackageProvider.c <span style="color: grey">(d0fc0043c9ef0b968d77bef71178aff8f9f06542)</span></li> <li>src/hardware/LMI_ChassisProvider.c <span style="color: grey">(2ef7342be0a0bab8ff7a9bf080df11be701469e1)</span></li> <li>src/hardware/LMI_PhysicalBatteryContainerProvider.c <span style="color: grey">(46bcad489c0873c6b383d8eb75d093cdba7e665d)</span></li> <li>src/hardware/LMI_PortPhysicalConnectorContainerProvider.c <span style="color: grey">(85fb16dc57411e799ed21302f743a0c8f0d802f1)</span></li> <li>src/hardware/LMI_ProcessorChipContainerProvider.c <span style="color: grey">(49a9bae14c7871f048dd4fa9e7833e38ace9cab2)</span></li> <li>src/hardware/LMI_SystemSlotContainerProvider.c <span style="color: grey">(c752fbea5ca6f606b84a3f4a613e887aab0f3215)</span></li> <li>src/hardware/dmidecode.h <span style="color: grey">(a29d90d8835da2b81d5d1e95fa38dd31c97b559f)</span></li> <li>src/hardware/dmidecode.c <span style="color: grey">(a171707f40c0b95465c620a5ea6f5e46a5699e35)</span></li> </ul> <p><a href="http://reviewboard-openlmi.rhcloud.com/r/644/diff/" style="margin-left: 3em;">View Diff</a></p> </td> </tr> </table> </div> </body> </html> --===============3985178097948602485==-- ]