[From nobody Thu Jul 18 12:35:33 2013 From: Jan Synacek <reviewboard@gallagherhome.com> Precedence: list MIME-Version: 1.0 To: "Peter Schiffer" <pschiffe@redhat.com>, "Jan Synacek" <jsynacek@redhat.com>, "OpenLMI Developers" <openlmi-reviews@lists.fedorahosted.org> References: <20130716144825.8319.81550@ex-std-node147.prod.rhcloud.com> In-Reply-To: <20130716144825.8319.81550@ex-std-node147.prod.rhcloud.com> Date: Wed, 17 Jul 2013 05:44:47 -0000 Reply-To: Jan Synacek <jsynacek@redhat.com>, openlmi-reviews@lists.fedorahosted.org Message-ID: <20130717054447.8319.17151@ex-std-node147.prod.rhcloud.com> Content-Type: multipart/alternative; boundary="===============1304715159809702314==" Subject: Re: Review Request 567: Hardware: Package the cmpiLMI_Hardware-cimprovagt file Message: 9 --===============1304715159809702314== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/567/#review679 ----------------------------------------------------------- Ship it! Ship It! - Jan Synacek On July 16, 2013, 4:48 p.m., Peter Schiffer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard-openlmi.rhcloud.com/r/567/ > ----------------------------------------------------------- > > (Updated July 16, 2013, 4:48 p.m.) > > > Review request for OpenLMI Developers. > > > Repository: openlmi-providers > > > Description > ------- > > Hardware: Package the cmpiLMI_Hardware-cimprovagt file > > Added and packaged the cmpiLMI_Hardware-cimprovagt file for hardware provider. > > > Diffs > ----- > > openlmi-providers.spec 6e6d8b7bade2c5b59a6844cc74613c4dbfd1c58a > src/hardware/CMakeLists.txt a9726825c5de525f249b317f14d0b88942070cc7 > src/hardware/cmpiLMI_Hardware-cimprovagt PRE-CREATION > > Diff: http://reviewboard-openlmi.rhcloud.com/r/567/diff/ > > > Testing > ------- > > > Thanks, > > Peter Schiffer > > --===============1304715159809702314== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit <html> <body> <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;"> <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;"> <tr> <td> This is an automatically generated e-mail. To reply, visit: <a href="http://reviewboard-openlmi.rhcloud.com/r/567/">http://reviewboard-openlmi.rhcloud.com/r/567/</a> </td> </tr> </table> <br /> <p>Ship it!</p> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> <br /> <p>- Jan Synacek</p> <br /> <p>On July 16th, 2013, 4:48 p.m. CEST, Peter Schiffer wrote:</p> <table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://reviewboard-openlmi.rhcloud.com/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;"> <tr> <td> <div>Review request for OpenLMI Developers.</div> <div>By Peter Schiffer.</div> <p style="color: grey;"><i>Updated July 16, 2013, 4:48 p.m.</i></p> <div style="margin-top: 1.5em;"> <b style="color: #575012; font-size: 10pt;">Repository: </b> openlmi-providers </div> <h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0"> <tr> <td> <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hardware: Package the cmpiLMI_Hardware-cimprovagt file Added and packaged the cmpiLMI_Hardware-cimprovagt file for hardware provider.</pre> </td> </tr> </table> <h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1> <ul style="margin-left: 3em; padding-left: 0;"> <li>openlmi-providers.spec <span style="color: grey">(6e6d8b7bade2c5b59a6844cc74613c4dbfd1c58a)</span></li> <li>src/hardware/CMakeLists.txt <span style="color: grey">(a9726825c5de525f249b317f14d0b88942070cc7)</span></li> <li>src/hardware/cmpiLMI_Hardware-cimprovagt <span style="color: grey">(PRE-CREATION)</span></li> </ul> <p><a href="http://reviewboard-openlmi.rhcloud.com/r/567/diff/" style="margin-left: 3em;">View Diff</a></p> </td> </tr> </table> </div> </body> </html> --===============1304715159809702314==-- ]