[From nobody Tue Jul 9 08:17:01 2013 From: Jan Synacek <reviewboard@gallagherhome.com> Precedence: list MIME-Version: 1.0 To: "OpenLMI Developers" <openlmi-reviews@lists.fedorahosted.org>, "Jan Synacek" <jsynacek@redhat.com>, "Radek Novacek" <rnovacek@redhat.com> References: <20130704134157.12732.37820@ex-std-node147.prod.rhcloud.com> In-Reply-To: <20130704134157.12732.37820@ex-std-node147.prod.rhcloud.com> Date: Mon, 08 Jul 2013 09:09:32 -0000 Reply-To: Jan Synacek <jsynacek@redhat.com>, openlmi-reviews@lists.fedorahosted.org Message-ID: <20130708090932.8319.88840@ex-std-node147.prod.rhcloud.com> Content-Type: multipart/alternative; boundary="===============1020506620979358486==" Subject: Re: Review Request 516: openlmi-networking <jobs> [2/5] Allow more affected elements in the job Message: 54 --===============1020506620979358486== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/516/#review623 ----------------------------------------------------------- Ship it! Ship It! - Jan Synacek On July 4, 2013, 3:41 p.m., Radek Novacek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard-openlmi.rhcloud.com/r/516/ > ----------------------------------------------------------- > > (Updated July 4, 2013, 3:41 p.m.) > > > Review request for OpenLMI Developers. > > > Repository: openlmi-networking > > > Description > ------- > > Allow more affected elements in the job > > Needed for LMI_AffectedNetworkJobElement implementation. > > > Diffs > ----- > > src/activeconnection.h 1fea3032ba74ce43b9e2cd0d82a9ca89901ad656 > src/activeconnection.c bb03a3d6b06444caec553c78553703bfc4705a48 > src/activeconnection_nm.c 840e13e08cfc25666f4aa4ae690dac7c1a60d4c9 > src/job.h 53277ebf3af1c7c9298dcdb9215bf2c36959bd8c > src/job.c d25b2fa6588a7d60c9aaae2e7917d2d36c1982b5 > src/network_nm.c d1455ff9ad0ede56361f1f1eb86b1c5faa424895 > > Diff: http://reviewboard-openlmi.rhcloud.com/r/516/diff/ > > > Testing > ------- > > > Thanks, > > Radek Novacek > > --===============1020506620979358486== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit <html> <body> <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;"> <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;"> <tr> <td> This is an automatically generated e-mail. To reply, visit: <a href="http://reviewboard-openlmi.rhcloud.com/r/516/">http://reviewboard-openlmi.rhcloud.com/r/516/</a> </td> </tr> </table> <br /> <p>Ship it!</p> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> <br /> <p>- Jan Synacek</p> <br /> <p>On July 4th, 2013, 3:41 p.m. CEST, Radek Novacek wrote:</p> <table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://reviewboard-openlmi.rhcloud.com/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;"> <tr> <td> <div>Review request for OpenLMI Developers.</div> <div>By Radek Novacek.</div> <p style="color: grey;"><i>Updated July 4, 2013, 3:41 p.m.</i></p> <div style="margin-top: 1.5em;"> <b style="color: #575012; font-size: 10pt;">Repository: </b> openlmi-networking </div> <h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0"> <tr> <td> <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Allow more affected elements in the job Needed for LMI_AffectedNetworkJobElement implementation. </pre> </td> </tr> </table> <h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1> <ul style="margin-left: 3em; padding-left: 0;"> <li>src/activeconnection.h <span style="color: grey">(1fea3032ba74ce43b9e2cd0d82a9ca89901ad656)</span></li> <li>src/activeconnection.c <span style="color: grey">(bb03a3d6b06444caec553c78553703bfc4705a48)</span></li> <li>src/activeconnection_nm.c <span style="color: grey">(840e13e08cfc25666f4aa4ae690dac7c1a60d4c9)</span></li> <li>src/job.h <span style="color: grey">(53277ebf3af1c7c9298dcdb9215bf2c36959bd8c)</span></li> <li>src/job.c <span style="color: grey">(d25b2fa6588a7d60c9aaae2e7917d2d36c1982b5)</span></li> <li>src/network_nm.c <span style="color: grey">(d1455ff9ad0ede56361f1f1eb86b1c5faa424895)</span></li> </ul> <p><a href="http://reviewboard-openlmi.rhcloud.com/r/516/diff/" style="margin-left: 3em;">View Diff</a></p> </td> </tr> </table> </div> </body> </html> --===============1020506620979358486==-- ]