<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://reviewboard-openlmi.rhcloud.com/r/279/">http://reviewboard-openlmi.rhcloud.com/r/279/</a>
     </td>
    </tr>
   </table>
   <br />



<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray solid;">
 <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
  </td>
 </tr>
</table>
<br />


<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://reviewboard-openlmi.rhcloud.com/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for OpenLMI Developers.</div>
<div>By Radek Novacek.</div>


<p style="color: grey;"><i>Updated May 10, 2013, 3:45 p.m.</i></p>









<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
openlmi-networking
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Add lots of error checking

Now most of the errors should be handled properly. The error codes still
needs to be converted to error messages and presented to users.
</pre>
  </td>
 </tr>
</table>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/LMI_BindsToLANEndpointProvider.c <span style="color: grey">(39b4186ab3702a797b9b9c153179f5a02351fd96)</span></li>

 <li>src/LMI_DNSProtocolEndpointProvider.c <span style="color: grey">(017eb11aa3444cd7c2a96188a53a8f006d2a3e8d)</span></li>

 <li>src/LMI_DNSSettingDataProvider.c <span style="color: grey">(6f0cbaf1b3aa6ce557c8b0f6975a29fee4feac11)</span></li>

 <li>src/LMI_EndpointForIPNetworkConnectionProvider.c <span style="color: grey">(00ef28d4851d6e896bfdddd9c600a07ce330cdc1)</span></li>

 <li>src/LMI_EthernetPortProvider.c <span style="color: grey">(0fa56f12881481d63834c7159c5534e5d8955e24)</span></li>

 <li>src/LMI_EthernetPortStatisticsProvider.c <span style="color: grey">(ffae836683d4a442d4be8b851a3b36453ac65f37)</span></li>

 <li>src/LMI_ExtendedStaticIPAssignmentSettingDataProvider.c <span style="color: grey">(731760368218c190f08cd6ebc2d5b2cb1174b8cc)</span></li>

 <li>src/LMI_IPAssignmentSettingDataProvider.c <span style="color: grey">(be1b866f4794d4d72c1784132f68005b3000422f)</span></li>

 <li>src/LMI_IPConfigurationServiceAffectsElementProvider.c <span style="color: grey">(874ab1dd6896267d7cadc4955224ed174ea72426)</span></li>

 <li>src/LMI_IPConfigurationServiceProvider.c <span style="color: grey">(364360b6509be87527bbbeca553e93cb55854053)</span></li>

 <li>src/LMI_IPElementSettingDataProvider.c <span style="color: grey">(5a26bc45f3dbe20b8fb42fe71001b45f31722813)</span></li>

 <li>src/LMI_IPNetworkConnectionCapabilitiesProvider.c <span style="color: grey">(3a1dfc4550f0b64fbd0515a5339c84c91f46e331)</span></li>

 <li>src/LMI_IPNetworkConnectionElementCapabilitiesProvider.c <span style="color: grey">(06ac9f33f3ae1a485ef615f83161fadb953024ac)</span></li>

 <li>src/LMI_IPNetworkConnectionProvider.c <span style="color: grey">(995fe9da4db24305ab09ea5b59d6db2867156347)</span></li>

 <li>src/LMI_IPProtocolEndpointProvider.c <span style="color: grey">(2df0131ec3b538d68b82a62e347ece6e399694e8)</span></li>

 <li>src/LMI_IPVersionElementSettingDataProvider.c <span style="color: grey">(5fdc5aa8637833aadeb962eaf4abfb09cef51ee7)</span></li>

 <li>src/LMI_IPVersionSettingDataProvider.c <span style="color: grey">(35d3525fb846cf1de5aa26421c7eeb49efb571ed)</span></li>

 <li>src/LMI_LAGPort8023adProvider.c <span style="color: grey">(b3d29bd37310cda7a3482fd9bdedcd594b6de2e5)</span></li>

 <li>src/LMI_LANEndpointProvider.c <span style="color: grey">(89a12931051e753cbd54c956f073719029500b46)</span></li>

 <li>src/LMI_LinkAggregationBindsToProvider.c <span style="color: grey">(836f581937e37638d082b117c3e015e386b0134a)</span></li>

 <li>src/LMI_LinkAggregationConcreteIdentityProvider.c <span style="color: grey">(6ad051049bd1f6df1d194245814a0f88e3809eef)</span></li>

 <li>src/LMI_LinkAggregator8023adProvider.c <span style="color: grey">(0f02ac8ff71575edcd4853dcc7ac26e3187c8a5a)</span></li>

 <li>src/LMI_NetworkDeviceSAPImplementationProvider.c <span style="color: grey">(9a4254331b8249e8ed26871fbd7ae97e72ee8721)</span></li>

 <li>src/LMI_NetworkElementCapabilitiesProvider.c <span style="color: grey">(df6768f7d19b4e869113d59112993a4078d0f444)</span></li>

 <li>src/LMI_NetworkHostedAccessPointProvider.c <span style="color: grey">(6c8829be9e20840dda978d3d58d0e9f108a97a16)</span></li>

 <li>src/LMI_NetworkRemoteAccessAvailableToElementProvider.c <span style="color: grey">(8df7f3ac03b40e4e4cff1a8480fc01c8ca9612c9)</span></li>

 <li>src/LMI_NetworkRemoteServiceAccessPointProvider.c <span style="color: grey">(cb42e0cf8b63787b681a029b63394fa0eb9f2d40)</span></li>

 <li>src/LMI_NetworkSAPSAPDependencyProvider.c <span style="color: grey">(23898d06dfa88677b6bb669cef81f0c9a16821be)</span></li>

 <li>src/LMI_NetworkSystemDeviceProvider.c <span style="color: grey">(410810d2dfa94606c34162e7de8b5a429ecd7f85)</span></li>

 <li>src/LMI_OrderedIPAssignmentComponentProvider.c <span style="color: grey">(1f3ddb92462e07f4bca7a1141a12cba702936cd5)</span></li>

 <li>src/activeconnection.c <span style="color: grey">(648c23fa2fdf616950758b6d1e58e78e3f6b20e4)</span></li>

 <li>src/activeconnection_nm.h <span style="color: grey">(c60d5da01cbe0254adb5272ff89b61d2c7737ef0)</span></li>

 <li>src/activeconnection_nm.c <span style="color: grey">(caef0042839b520f430f5676e88d52392962e93e)</span></li>

 <li>src/connection.h <span style="color: grey">(49c4b85f07a8c09acff6bd3530c045580847f4cc)</span></li>

 <li>src/connection.c <span style="color: grey">(58c7b8d9b9ea6a95094368da853d89fa178d6c64)</span></li>

 <li>src/connection_nm.h <span style="color: grey">(8a43bd068717a4961ba986705c277fecf518aec3)</span></li>

 <li>src/connection_nm.c <span style="color: grey">(2c6eab8926012089b8364dce6652c571686f473d)</span></li>

 <li>src/connection_private.h <span style="color: grey">(821e9fd765ab24e9262665540d03a28c91d6c2ab)</span></li>

 <li>src/dbus_wrapper.c <span style="color: grey">(a2d1e98a7cba16036d02a39bf314511b90d4f816)</span></li>

 <li>src/errors.h <span style="color: grey">(bbeec9b4fc7959f23209a6807527a2f86dbc00c8)</span></li>

 <li>src/globals.h <span style="color: grey">(e06b5f4fd595c277370e5ef98ac37dfd69023550)</span></li>

 <li>src/globals.c <span style="color: grey">(f7ce75d47d139910e13b0eec51ec537b1bca37f4)</span></li>

 <li>src/ipassignmentsettingdata.c <span style="color: grey">(1a9501e04fcf8791b54deb719fd8c3c1d32f4633)</span></li>

 <li>src/ipconfig.c <span style="color: grey">(575a37ce0f17aa1928d3bcd686bdccaaafbfa5a2)</span></li>

 <li>src/network.h <span style="color: grey">(9a70c28ffec537e9fdb441ea96d27e32f0da5ea3)</span></li>

 <li>src/network.c <span style="color: grey">(8b64c0f06704d5a5644215f6a9af125c8ca0c598)</span></li>

 <li>src/network_nm.c <span style="color: grey">(24455f3b0d0002424449bde12c854d19ad6591fe)</span></li>

 <li>src/network_private.h <span style="color: grey">(27fe247e6bfc6a0381d93f23c8e0953571461cbc)</span></li>

 <li>src/nm_support.h <span style="color: grey">(7f8b6cabb504ee88a6e5af16eade7e4aeddb004f)</span></li>

 <li>src/nm_support.c <span style="color: grey">(272bd3ebef44b5b0a2b40ee0cba31b42cc7e9f94)</span></li>

 <li>src/port.h <span style="color: grey">(a249c8b34ce629f7539d562926928f7a44031fc9)</span></li>

 <li>src/port.c <span style="color: grey">(4b5cd96b94b4448acb3f0498b17d74b5133f3d39)</span></li>

 <li>src/port_nm.c <span style="color: grey">(d3d123788d673dc40491e58a23001e8d16370ff9)</span></li>

 <li>src/ref_factory.c <span style="color: grey">(641e387374e00a296e155194e5a468414998625d)</span></li>

 <li>src/setting.h <span style="color: grey">(1f678c3a6c96fc26184c90089539bfaffc433e3e)</span></li>

 <li>src/setting.c <span style="color: grey">(e05ed50ac3b2a13806f6abe032a0e588d81e39c9)</span></li>

 <li>src/setting_nm.h <span style="color: grey">(6f626b83a2c2b70ba0a4ce9ff233be54fc7ebe28)</span></li>

 <li>src/setting_nm.c <span style="color: grey">(c005917c0d4bb72d715a32eabfb132a06c8983bc)</span></li>

 <li>src/unittest/mock_nm.c <span style="color: grey">(7509b493418bbacd5294a1a16a0da19147a7087e)</span></li>

 <li>src/unittest/test.h <span style="color: grey">(4997906c65f646a785ccdb4e9bb90ecc1f549ac7)</span></li>

 <li>src/unittest/test_connection.c <span style="color: grey">(5d4c9bdb4590e8181aa8d70f96f24162be0bd8c4)</span></li>

 <li>src/unittest/test_network.c <span style="color: grey">(75ef1d602fb09353cb5da871012615ac68bb3968)</span></li>

 <li>src/unittest/test_setting.c <span style="color: grey">(a03b51b45df266372212ab6d925434b2daec6bcc)</span></li>

</ul>

<p><a href="http://reviewboard-openlmi.rhcloud.com/r/279/diff/" style="margin-left: 3em;">View Diff</a></p>







  </td>
 </tr>
</table>




  </div>
 </body>
</html>