<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://reviewboard-openlmi.rhcloud.com/r/315/">http://reviewboard-openlmi.rhcloud.com/r/315/</a>
     </td>
    </tr>
   </table>
   <br />





 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">There is a lot of changes here, I suppose it&#39;s because the patch is against some different version of openlmi-networking. If your patch only adds the .reviewboard file, feel free to ship it.</pre>
 <br />









<p>- Radek</p>


<br />
<p>On May 8th, 2013, 3:53 p.m. CEST, Stephen Gallagher wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://reviewboard-openlmi.rhcloud.com/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for OpenLMI Developers.</div>
<div>By Stephen Gallagher.</div>


<p style="color: grey;"><i>Updated May 8, 2013, 3:53 p.m.</i></p>









<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
openlmi-networking
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Add .reviewboardrc configuration file</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review submission</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>.reviewboardrc <span style="color: grey">(PRE-CREATION)</span></li>

 <li>mof/LMI_Networking.mof <span style="color: grey">(61a0bff26e0b879ea9c986449419686124898562)</span></li>

 <li>src/CMakeLists.txt <span style="color: grey">(f0f1ea7f22e85298f69074aa7ce6a9c6c26eb38e)</span></li>

 <li>src/LMI_BindsToLANEndpointProvider.c <span style="color: grey">(b273f83828f2e57b6906f2987b3cae268f7f6a0f)</span></li>

 <li>src/LMI_DHCPSettingDataProvider.c <span style="color: grey">(032933d726cb557e4768bf5e6854de9d9bf2d66b)</span></li>

 <li>src/LMI_DNSProtocolEndpointProvider.c <span style="color: grey">(227ab615a893da9963cf2c84d0d7eda396fa74ba)</span></li>

 <li>src/LMI_DNSSettingDataProvider.c <span style="color: grey">(8292afd216145eddb3cdcb0857ab15217d3726e5)</span></li>

 <li>src/LMI_EndpointForIPNetworkConnectionProvider.c <span style="color: grey">(86e040eb8fbc25197318abf89780d60b121e19da)</span></li>

 <li>src/LMI_EthernetPortProvider.c <span style="color: grey">(b16b7e1c1237ba0b4d1ef830cc79d1a394d92bc9)</span></li>

 <li>src/LMI_EthernetPortStatisticsProvider.c <span style="color: grey">(9aa855b533a77fb127c75a56310e9d73523fb2b3)</span></li>

 <li>src/LMI_ExtendedStaticIPAssignmentSettingDataProvider.c <span style="color: grey">(c0500515de89abff407b8b52bc6151d4c2d6be64)</span></li>

 <li>src/LMI_HostedIPConfigurationServiceProvider.c <span style="color: grey">(f1ab7e588908641a6e10820b480f36f2838ea010)</span></li>

 <li>src/LMI_IPAssignmentSettingDataProvider.c <span style="color: grey">(c3b632c49378233432945cbb8bd3f215425b96ae)</span></li>

 <li>src/LMI_IPConfigurationServiceAffectsElementProvider.c <span style="color: grey">(a9256742ea4bcd61ad999898c43bb75002a74d11)</span></li>

 <li>src/LMI_IPConfigurationServiceProvider.c <span style="color: grey">(a98132789a36bed7837f9b23872eaeb84d5c2c8d)</span></li>

 <li>src/LMI_IPElementSettingDataProvider.c <span style="color: grey">(7c9cab4fc07714a6d8df1abc49cbed20d526efaf)</span></li>

 <li>src/LMI_IPNetworkConnectionCapabilitiesProvider.c <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/LMI_IPNetworkConnectionElementCapabilitiesProvider.c <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/LMI_IPNetworkConnectionProvider.c <span style="color: grey">(b63f7678de11dbac939c107a44f1d269da3554c0)</span></li>

 <li>src/LMI_IPProtocolEndpointProvider.c <span style="color: grey">(513cebfc77952e7daca433dd8c01a02f340c9c3d)</span></li>

 <li>src/LMI_IPVersionElementSettingDataProvider.c <span style="color: grey">(67cc0edcb638e72ab566a6113787770042f868e0)</span></li>

 <li>src/LMI_IPVersionSettingDataProvider.c <span style="color: grey">(04aae1eac6afe594a63e920797da61c9ccc76bf2)</span></li>

 <li>src/LMI_LAGPort8023adProvider.c <span style="color: grey">(b7554a8a7faf91685bf1bb759f39cb8aa86ffd09)</span></li>

 <li>src/LMI_LANEndpointProvider.c <span style="color: grey">(2b7b8b64f690644c3c5feb3702b4f2fb642b01cd)</span></li>

 <li>src/LMI_LinkAggregationBindsToProvider.c <span style="color: grey">(ba2c5ce9699267d75e0c1211da8f5137082db867)</span></li>

 <li>src/LMI_LinkAggregationConcreteIdentityProvider.c <span style="color: grey">(91b135503daf66a4649974c7fc6c15c018404566)</span></li>

 <li>src/LMI_LinkAggregator8023adProvider.c <span style="color: grey">(b9e8f177ab29a620e21323b255732971c08312a9)</span></li>

 <li>src/LMI_NetworkDeviceSAPImplementationProvider.c <span style="color: grey">(6e29d2c913a6450c565c952790a8e34f15ed8096)</span></li>

 <li>src/LMI_NetworkElementCapabilitiesProvider.c <span style="color: grey">(1c6146ac7cbc7ce2d4607d6d79baceca15fda519)</span></li>

 <li>src/LMI_NetworkEnabledLogicalElementCapabilitiesProvider.c <span style="color: grey">(9b5b2b90cfe1ba9442458eca26bd92e63c99d482)</span></li>

 <li>src/LMI_NetworkHostedAccessPointProvider.c <span style="color: grey">(f1da7df3cc9eded1a61a2d1fd1024334a3d3a943)</span></li>

 <li>src/LMI_NetworkRemoteAccessAvailableToElementProvider.c <span style="color: grey">(11c076f98b7c282742fa3954a29cc883892a8509)</span></li>

 <li>src/LMI_NetworkRemoteServiceAccessPointProvider.c <span style="color: grey">(1dce18d88c310ded20323db9a506a34cf534d4ec)</span></li>

 <li>src/LMI_NetworkSAPSAPDependencyProvider.c <span style="color: grey">(3440fd49735006477f108b01116bd17d891c45c1)</span></li>

 <li>src/LMI_NetworkSystemDeviceProvider.c <span style="color: grey">(50c4227bdf3fbeeb1aa4299e131e8d7a24ee2d89)</span></li>

 <li>src/LMI_OrderedIPAssignmentComponentProvider.c <span style="color: grey">(9d3a92e6c6cf3e02a706c15e2509783e6fc4b252)</span></li>

 <li>src/activeconnection_nm.c <span style="color: grey">(015ff9800c7ec5a0bced6647aeaf44565018199f)</span></li>

 <li>src/connection.h <span style="color: grey">(8ebb4dd04bb135e6fa94f0dd3a4ac32b77a983c2)</span></li>

 <li>src/connection.c <span style="color: grey">(31dd820014483760277fc1118ad9839531cc4260)</span></li>

 <li>src/connection_nm.c <span style="color: grey">(65dcaa989b7585c7bf1eba1b6a992e1122ad9b6d)</span></li>

 <li>src/connection_private.h <span style="color: grey">(b3304d6764784d0d2fff64147c419362aed58816)</span></li>

 <li>src/errors.h <span style="color: grey">(49a58cd1434d70cf4266536a326c3bbeaaf37899)</span></li>

 <li>src/globals.h <span style="color: grey">(59162c9ebd447734287a7a4e94c3cc2de5d46b6c)</span></li>

 <li>src/globals.c <span style="color: grey">(289469a83ef21980242055fef193954bf8d04ac8)</span></li>

 <li>src/ipassignmentsettingdata.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/ipassignmentsettingdata.c <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/network.h <span style="color: grey">(2ebfb7fd3211790702980ec6eb182075675a880d)</span></li>

 <li>src/network.c <span style="color: grey">(8aca260a7428f59d77a0f4cb717eb07719c3a97e)</span></li>

 <li>src/network_nm.c <span style="color: grey">(c5426362030ffd8f5735043861580bb77ba87a7e)</span></li>

 <li>src/nm_support.c <span style="color: grey">(5b8783f8c2d2064baa9f59aaf4209cadb432d774)</span></li>

 <li>src/port.h <span style="color: grey">(1498aa5efc72ba86dfe5cebbefe6e565b8cef590)</span></li>

 <li>src/port.c <span style="color: grey">(ba6944dcbf9d4dd91567825937c23391e2e14bbb)</span></li>

 <li>src/port_nm.c <span style="color: grey">(7e72aa3510933f5b87674297dcebbaf87295e35b)</span></li>

 <li>src/port_private.h <span style="color: grey">(b20b176b47e1878a47a49477b8c719f016250d8c)</span></li>

 <li>src/ref_factory.c <span style="color: grey">(5eec08a7e9a6b9236185dc79ed35719520eac190)</span></li>

 <li>src/setting.h <span style="color: grey">(514e7f0469085e73d3293a060752a0193816d9fd)</span></li>

 <li>src/setting.c <span style="color: grey">(25fa7cbad6e8d52359d0142c7210fa8e6a9d5d71)</span></li>

 <li>src/setting_nm.c <span style="color: grey">(d6bbafa31d26d7784ec7f578dc205cd4113a4497)</span></li>

 <li>src/unittest/mock_nm.c <span style="color: grey">(5a3cea46788c74c5b654aeb73bc1b6154425b27b)</span></li>

 <li>src/unittest/test.h <span style="color: grey">(0db0dc94895a91b640c991f39ba745a13720e5fc)</span></li>

 <li>src/unittest/test_connection.c <span style="color: grey">(b5f2e37bad9c0ce87b0bc6b91b63f45605fb24a8)</span></li>

 <li>src/unittest/test_dbus.c <span style="color: grey">(ec55a09e1dd1832f3797f317f7da4b2a061eac16)</span></li>

 <li>src/unittest/test_network.c <span style="color: grey">(c2989b6f881a96976883ceabdaebc392f0016b84)</span></li>

 <li>src/unittest/test_setting.c <span style="color: grey">(33e61b92493c70c84cb00d030fbd52a7ce9fdeaf)</span></li>

 <li>test/objects.json <span style="color: grey">(b346e1f660322c13151cd6240e37baa20dfd3e29)</span></li>

 <li>test/test_apply_connection.py <span style="color: grey">(PRE-CREATION)</span></li>

 <li>test/test_bonding.py <span style="color: grey">(64ad5c8908d8b30d04e4cddde74343cb97693a5d)</span></li>

 <li>test/test_create_destroy_connection.py <span style="color: grey">(a68d32bc39cbd703884315e9fd594228ebc59522)</span></li>

 <li>test/test_enable_disable_iface.py <span style="color: grey">(792d3ade8a854ecea38b70ac7d73e157f59f0e53)</span></li>

 <li>test/test_modify_connection.py <span style="color: grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="http://reviewboard-openlmi.rhcloud.com/r/315/diff/" style="margin-left: 3em;">View Diff</a></p>







  </td>
 </tr>
</table>








  </div>
 </body>
</html>