<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://reviewboard-openlmi.rhcloud.com/r/310/">http://reviewboard-openlmi.rhcloud.com/r/310/</a>
     </td>
    </tr>
   </table>
   <br />




<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://reviewboard-openlmi.rhcloud.com/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for OpenLMI Developers and John Dennis.</div>
<div>By stefw.</div>


<p style="color: grey;"><i>Updated May 9, 2013, 11:33 a.m.</i></p>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Adding John Dennis to this review discussion.

John, can you answer Radek&#39;s question?</pre>
  </td>
 </tr>
</table>







<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
openlmi-providers
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Fix warnings:

15:08:34 **** Build of configuration Default for project openlmi-providers ****
make all 
[ 11%] Built target openlmicommon
[ 22%] Building C object src/realmd/CMakeFiles/cmpiLMI_Realmd.dir/LMI_HostedRealmdServiceProvider.c.o
In file included from /data/projects/openlmi-providers/src/realmd/LMI_HostedRealmdServiceProvider.c:5:0:
/data/projects/openlmi-providers/src/globals.h:33:0: warning: &quot;ORGID&quot; redefined [enabled by default]
 #define ORGID &quot;LMI&quot;
 ^
In file included from /data/projects/openlmi-providers/src/realmd/LMI_HostedRealmdServiceProvider.c:4:0:
/data/projects/openlmi-providers/src/realmd/rdcp_util.h:12:0: note: this is the location of the previous definition
 #define ORGID &quot;LMI_Realmd&quot;
 ^
/data/projects/openlmi-providers/src/realmd/LMI_HostedRealmdServiceProvider.c:233:28: warning: ISO C does not allow extra ‘;’ outside of a function [-Wpedantic]
     &quot;instance association&quot;);
                            ^
[ 33%] Building C object src/realmd/CMakeFiles/cmpiLMI_Realmd.dir/LMI_RealmdKerberosRealmProvider.c.o
In file included from /data/projects/openlmi-providers/src/realmd/LMI_RealmdKerberosRealmProvider.c:6:0:
/data/projects/openlmi-providers/src/realmd/rdcp_util.h:12:0: warning: &quot;ORGID&quot; redefined [enabled by default]
 #define ORGID &quot;LMI_Realmd&quot;
 ^
In file included from /data/projects/openlmi-providers/src/realmd/LMI_RealmdKerberosRealmProvider.c:3:0:
/data/projects/openlmi-providers/src/globals.h:33:0: note: this is the location of the previous definition
 #define ORGID &quot;LMI&quot;
 ^
/data/projects/openlmi-providers/src/realmd/LMI_RealmdKerberosRealmProvider.c:627:23: warning: ISO C does not allow extra ‘;’ outside of a function [-Wpedantic]
     &quot;instance method&quot;);
                       ^
[ 44%] Building C object src/realmd/CMakeFiles/cmpiLMI_Realmd.dir/LMI_RealmdRealmProvider.c.o
In file included from /data/projects/openlmi-providers/src/realmd/LMI_RealmdRealmProvider.c:7:0:
/data/projects/openlmi-providers/src/realmd/rdcp_util.h:12:0: warning: &quot;ORGID&quot; redefined [enabled by default]
 #define ORGID &quot;LMI_Realmd&quot;
 ^
In file included from /data/projects/openlmi-providers/src/realmd/LMI_RealmdRealmProvider.c:4:0:
/data/projects/openlmi-providers/src/globals.h:33:0: note: this is the location of the previous definition
 #define ORGID &quot;LMI&quot;
 ^
/data/projects/openlmi-providers/src/realmd/LMI_RealmdRealmProvider.c:326:23: warning: ISO C does not allow extra ‘;’ outside of a function [-Wpedantic]
     &quot;instance method&quot;);
                       ^
[ 55%] Building C object src/realmd/CMakeFiles/cmpiLMI_Realmd.dir/LMI_RealmdServiceProvider.c.o
In file included from /data/projects/openlmi-providers/src/realmd/LMI_RealmdServiceProvider.c:6:0:
/data/projects/openlmi-providers/src/realmd/rdcp_util.h:12:0: warning: &quot;ORGID&quot; redefined [enabled by default]
 #define ORGID &quot;LMI_Realmd&quot;
 ^
In file included from /data/projects/openlmi-providers/src/realmd/LMI_RealmdServiceProvider.c:3:0:
/data/projects/openlmi-providers/src/globals.h:33:0: note: this is the location of the previous definition
 #define ORGID &quot;LMI&quot;
 ^
/data/projects/openlmi-providers/src/realmd/LMI_RealmdServiceProvider.c:631:23: warning: ISO C does not allow extra ‘;’ outside of a function [-Wpedantic]
     &quot;instance method&quot;);
                       ^
[ 66%] Building C object src/realmd/CMakeFiles/cmpiLMI_Realmd.dir/LMI_ServiceAffectsRealmdRealmProvider.c.o
In file included from /data/projects/openlmi-providers/src/realmd/LMI_ServiceAffectsRealmdRealmProvider.c:4:0:
/data/projects/openlmi-providers/src/globals.h:33:0: warning: &quot;ORGID&quot; redefined [enabled by default]
 #define ORGID &quot;LMI&quot;
 ^
In file included from /data/projects/openlmi-providers/src/realmd/LMI_ServiceAffectsRealmdRealmProvider.c:3:0:
/data/projects/openlmi-providers/src/realmd/rdcp_util.h:12:0: note: this is the location of the previous definition
 #define ORGID &quot;LMI_Realmd&quot;
 ^
/data/projects/openlmi-providers/src/realmd/LMI_ServiceAffectsRealmdRealmProvider.c:252:28: warning: ISO C does not allow extra ‘;’ outside of a function [-Wpedantic]
     &quot;instance association&quot;);
                            ^
[ 77%] Building C object src/realmd/CMakeFiles/cmpiLMI_Realmd.dir/rdcp_dbus.c.o
/data/projects/openlmi-providers/src/realmd/rdcp_dbus.c:697:1: warning: ‘dbus_method_append_args_tuple’ defined but not used [-Wunused-function]
 dbus_method_append_args_tuple(DBusMessage  *message, GVariant *args, GError **g_error)
 ^
/data/projects/openlmi-providers/src/realmd/rdcp_dbus.c:777:1: warning: ‘marshal_dbus_dict_string_entry’ defined but not used [-Wunused-function]
 marshal_dbus_dict_string_entry(DBusMessageIter *array, const char *name, const char *value, GError **g_error)
 ^
[ 88%] Building C object src/realmd/CMakeFiles/cmpiLMI_Realmd.dir/rdcp_error.c.o
[100%] Building C object src/realmd/CMakeFiles/cmpiLMI_Realmd.dir/rdcp_util.c.o
Linking C shared library libcmpiLMI_Realmd.so
Generating .reg file from library for Realmd
[100%] Built target cmpiLMI_Realmd

15:08:37 Build Finished (took 3s.194ms)

</pre>
  </td>
 </tr>
</table>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/globals.h <span style="color: grey">(094602f71ac6ffeb1b0162320227bc8a9f935359)</span></li>

 <li>src/realmd/LMI_RealmdKerberosRealmProvider.c <span style="color: grey">(5dc90d2b5faefe264c652d054d4770d57ee02fe4)</span></li>

 <li>src/realmd/LMI_RealmdRealmProvider.c <span style="color: grey">(d8e0a188f0f822004c4f082fb52730c61479bef1)</span></li>

 <li>src/realmd/LMI_RealmdServiceProvider.c <span style="color: grey">(01fc0b839d0cc7267ef623bba9aad14581fc585d)</span></li>

</ul>

<p><a href="http://reviewboard-openlmi.rhcloud.com/r/310/diff/" style="margin-left: 3em;">View Diff</a></p>







  </td>
 </tr>
</table>




  </div>
 </body>
</html>