<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://reviewboard-openlmi.rhcloud.com/r/279/">http://reviewboard-openlmi.rhcloud.com/r/279/</a>
     </td>
    </tr>
   </table>
   <br />











<div>




<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
 <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
    <a href="http://reviewboard-openlmi.rhcloud.com/r/279/diff/1/?file=1536#file1536line84" style="color: black; font-weight: bold; text-decoration: underline;">src/LMI_BindsToLANEndpointProvider.c</a>
    <span style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">static CMPIStatus LMI_BindsToLANEndpointEnumInstances(</pre></td>

  </tr>
 </tbody>



 
 

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
    <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
    <th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">84</font></th>
    <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">            <span class="n">error</span><span class="p">(</span><span class="s">&quot;Unable to get reference to LMI_LANEndpoint&quot;</span><span class="p">);</span></pre></td>
  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It&#39;s on more places; I&#39;m not sure if you need to say the class name. If so, it will be good to use macro.</pre>
</div>
<br />

<div>




<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
 <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
    <a href="http://reviewboard-openlmi.rhcloud.com/r/279/diff/1/?file=1555#file1555line178" style="color: black; font-weight: bold; text-decoration: underline;">src/ipassignmentsettingdata.c</a>
    <span style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">CMPIStatus IPAssignmentSettingDataEnumInstances(</pre></td>

  </tr>
 </tbody>



 
 

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
    <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
    <th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">178</font></th>
    <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">                <span class="k">if</span> <span class="p">(</span><span class="n">instanceid</span> <span class="o">==</span> <span class="nb">NULL</span><span class="p">)</span> <span class="p">{</span></pre></td>
  </tr>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
    <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
    <th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">179</font></th>
    <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">                    <span class="n">CMSetStatus</span><span class="p">(</span><span class="o">&amp;</span><span class="n">res</span><span class="p">,</span> <span class="n">CMPI_RC_ERR_FAILED</span><span class="p">);</span></pre></td>
  </tr>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
    <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
    <th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">180</font></th>
    <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">                    <span class="k">break</span><span class="p">;</span></pre></td>
  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It&#39;s on more places - missing error message?</pre>
</div>
<br />



<p>- Roman</p>


<br />
<p>On April 29th, 2013, 7:14 a.m. UTC, Radek Novacek wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://reviewboard-openlmi.rhcloud.com/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for OpenLMI Developers.</div>
<div>By Radek Novacek.</div>


<p style="color: grey;"><i>Updated April 29, 2013, 7:14 a.m.</i></p>









<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
openlmi-networking
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Add lots of error checking

Now most of the errors should be handled properly. The error codes still
needs to be converted to error messages and presented to users.
</pre>
  </td>
 </tr>
</table>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/LMI_BindsToLANEndpointProvider.c <span style="color: grey">(39b4186ab3702a797b9b9c153179f5a02351fd96)</span></li>

 <li>src/LMI_DNSProtocolEndpointProvider.c <span style="color: grey">(017eb11aa3444cd7c2a96188a53a8f006d2a3e8d)</span></li>

 <li>src/LMI_DNSSettingDataProvider.c <span style="color: grey">(a3d74623b4c801b9241a3efcf2c70f6f2c20c660)</span></li>

 <li>src/LMI_EthernetPortStatisticsProvider.c <span style="color: grey">(ffae836683d4a442d4be8b851a3b36453ac65f37)</span></li>

 <li>src/LMI_ExtendedStaticIPAssignmentSettingDataProvider.c <span style="color: grey">(e4d9a14e63343ada59ac3db82c36f31cf03f3b3a)</span></li>

 <li>src/LMI_IPConfigurationServiceAffectsElementProvider.c <span style="color: grey">(874ab1dd6896267d7cadc4955224ed174ea72426)</span></li>

 <li>src/LMI_IPNetworkConnectionCapabilitiesProvider.c <span style="color: grey">(4dab5c55b87879ccde2a0a59806f1efa22e14c8d)</span></li>

 <li>src/activeconnection.c <span style="color: grey">(648c23fa2fdf616950758b6d1e58e78e3f6b20e4)</span></li>

 <li>src/activeconnection_nm.h <span style="color: grey">(c60d5da01cbe0254adb5272ff89b61d2c7737ef0)</span></li>

 <li>src/activeconnection_nm.c <span style="color: grey">(caef0042839b520f430f5676e88d52392962e93e)</span></li>

 <li>src/connection.h <span style="color: grey">(7e6d6206bae139a0d4d066f400ae78b0c70ab12d)</span></li>

 <li>src/connection.c <span style="color: grey">(969232810f0342d15f8e75c64bf841b6a42b065f)</span></li>

 <li>src/connection_nm.h <span style="color: grey">(8a43bd068717a4961ba986705c277fecf518aec3)</span></li>

 <li>src/connection_nm.c <span style="color: grey">(a5fba58e1eab8f5dc5ba3793ad247da8dbf404e0)</span></li>

 <li>src/connection_private.h <span style="color: grey">(821e9fd765ab24e9262665540d03a28c91d6c2ab)</span></li>

 <li>src/dbus_wrapper.c <span style="color: grey">(a2d1e98a7cba16036d02a39bf314511b90d4f816)</span></li>

 <li>src/errors.h <span style="color: grey">(bbeec9b4fc7959f23209a6807527a2f86dbc00c8)</span></li>

 <li>src/globals.h <span style="color: grey">(e06b5f4fd595c277370e5ef98ac37dfd69023550)</span></li>

 <li>src/globals.c <span style="color: grey">(f7ce75d47d139910e13b0eec51ec537b1bca37f4)</span></li>

 <li>src/ipassignmentsettingdata.c <span style="color: grey">(78489a83d262b4e78546c654e16c7a9a2401172f)</span></li>

 <li>src/ipconfig.c <span style="color: grey">(575a37ce0f17aa1928d3bcd686bdccaaafbfa5a2)</span></li>

 <li>src/network.h <span style="color: grey">(9a70c28ffec537e9fdb441ea96d27e32f0da5ea3)</span></li>

 <li>src/network.c <span style="color: grey">(8b64c0f06704d5a5644215f6a9af125c8ca0c598)</span></li>

 <li>src/network_nm.c <span style="color: grey">(24455f3b0d0002424449bde12c854d19ad6591fe)</span></li>

 <li>src/network_private.h <span style="color: grey">(27fe247e6bfc6a0381d93f23c8e0953571461cbc)</span></li>

 <li>src/nm_support.h <span style="color: grey">(7f8b6cabb504ee88a6e5af16eade7e4aeddb004f)</span></li>

 <li>src/nm_support.c <span style="color: grey">(272bd3ebef44b5b0a2b40ee0cba31b42cc7e9f94)</span></li>

 <li>src/port.h <span style="color: grey">(a249c8b34ce629f7539d562926928f7a44031fc9)</span></li>

 <li>src/port.c <span style="color: grey">(4b5cd96b94b4448acb3f0498b17d74b5133f3d39)</span></li>

 <li>src/port_nm.c <span style="color: grey">(d3d123788d673dc40491e58a23001e8d16370ff9)</span></li>

 <li>src/setting.h <span style="color: grey">(80e8591f98c8378aff2ea4389f69a8f67df2578b)</span></li>

 <li>src/setting.c <span style="color: grey">(91e311779829b23c927660add0bc68e479e655a4)</span></li>

 <li>src/setting_nm.h <span style="color: grey">(6f626b83a2c2b70ba0a4ce9ff233be54fc7ebe28)</span></li>

 <li>src/setting_nm.c <span style="color: grey">(c005917c0d4bb72d715a32eabfb132a06c8983bc)</span></li>

 <li>src/unittest/mock_nm.c <span style="color: grey">(7509b493418bbacd5294a1a16a0da19147a7087e)</span></li>

 <li>src/unittest/test.h <span style="color: grey">(0db0dc94895a91b640c991f39ba745a13720e5fc)</span></li>

 <li>src/unittest/test_connection.c <span style="color: grey">(5d4c9bdb4590e8181aa8d70f96f24162be0bd8c4)</span></li>

 <li>src/unittest/test_network.c <span style="color: grey">(f1e8fe9692428679e1a79373575a098239456230)</span></li>

 <li>src/unittest/test_setting.c <span style="color: grey">(a03b51b45df266372212ab6d925434b2daec6bcc)</span></li>

</ul>

<p><a href="http://reviewboard-openlmi.rhcloud.com/r/279/diff/" style="margin-left: 3em;">View Diff</a></p>







  </td>
 </tr>
</table>








  </div>
 </body>
</html>