<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://reviewboard-openlmi.rhcloud.com/r/253/">http://reviewboard-openlmi.rhcloud.com/r/253/</a>
     </td>
    </tr>
   </table>
   <br />











<div>




<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
 <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
    <a href="http://reviewboard-openlmi.rhcloud.com/r/253/diff/1/?file=1404#file1404line791" style="color: black; font-weight: bold; text-decoration: underline;">src/hardware/dmidecode.c</a>
    <span style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">short dmi_get_memory(DmiMemory *memory)</pre></td>

  </tr>
 </tbody>



 
 

 <tbody>

  <tr>
    <th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">726</font></th>
    <td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span class="kt">short</span> <span class="n">ret</span> <span class="o">=</span> <span class="o">-</span><span class="mi">1</span><span class="p">;</span></pre></td>
    <th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">791</font></th>
    <td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span class="kt">short</span> <span class="n">ret</span> <span class="o">=</span> <span class="o">-</span><span class="mi">1</span><span class="p">;</span></pre></td>
  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Will not open an issue, but I will use some enum which will represents return values.</pre>
</div>
<br />



<p>- Roman</p>


<br />
<p>On April 23rd, 2013, 1:54 p.m. UTC, Peter Schiffer wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://reviewboard-openlmi.rhcloud.com/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for OpenLMI Developers.</div>
<div>By Peter Schiffer.</div>


<p style="color: grey;"><i>Updated April 23, 2013, 1:54 p.m.</i></p>









<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
openlmi-providers
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hardware: Added Physical Memory Provider

New Providers:
 * LMI_PhysicalMemoryProvider
 * LMI_PhysicalMemoryRealizesProvider

Other Changes:
 * Fixed InstanceID in hardware to match the rest of the providers
 * Removed some unused variables</pre>
  </td>
 </tr>
</table>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>mof/60_LMI_Hardware.mof <span style="color: grey">(3ceb88691d45c6b8f2f0d41a4a5f2464d04ee9df)</span></li>

 <li>src/hardware/LMI_Hardware.h <span style="color: grey">(19a8ff70decd76916963844dfa2a0098793010b0)</span></li>

 <li>src/hardware/LMI_MemoryProvider.c <span style="color: grey">(6c9a2ec1fd0c54a0fd355f32749758f0c9290926)</span></li>

 <li>src/hardware/LMI_PhysicalMemoryProvider.c <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/hardware/LMI_PhysicalMemoryRealizesProvider.c <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/hardware/LMI_ProcessorCacheMemoryProvider.c <span style="color: grey">(030ddd154c029217bba90b1dcfbfd16b1d436651)</span></li>

 <li>src/hardware/LMI_ProcessorCapabilitiesProvider.c <span style="color: grey">(c7711242aa14d6ea585eed2f4337f772a2d6a176)</span></li>

 <li>src/hardware/LMI_ProcessorChipProvider.c <span style="color: grey">(47ba488995976313c1def5a4269e55b1bbf051c3)</span></li>

 <li>src/hardware/LMI_ProcessorChipRealizesProvider.c <span style="color: grey">(6dfd4bfb91bd25b1a4c13d816766ae7b56e5286d)</span></li>

 <li>src/hardware/LMI_ProcessorElementCapabilitiesProvider.c <span style="color: grey">(322e966103f6e4acc6b69ec7269505bd3c6cff5f)</span></li>

 <li>src/hardware/LMI_ProcessorProvider.c <span style="color: grey">(c14b10568f1296850b6a605c2453e6a40339ea83)</span></li>

 <li>src/hardware/dmidecode.h <span style="color: grey">(d3320ea5018ff92277760a82b3be24ecdfa050a7)</span></li>

 <li>src/hardware/dmidecode.c <span style="color: grey">(367a08c1f2264a186ee45d72da28426c09e54821)</span></li>

</ul>

<p><a href="http://reviewboard-openlmi.rhcloud.com/r/253/diff/" style="margin-left: 3em;">View Diff</a></p>







  </td>
 </tr>
</table>








  </div>
 </body>
</html>