<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://reviewboard-openlmi.rhcloud.com/r/241/">http://reviewboard-openlmi.rhcloud.com/r/241/</a>
     </td>
    </tr>
   </table>
   <br />











<div>




<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
 <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
    <a href="http://reviewboard-openlmi.rhcloud.com/r/241/diff/1/?file=1345#file1345line67" style="color: black; font-weight: bold; text-decoration: underline;">src/software/openlmi/software/yumdb/jobmanager.py</a>
    <span style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>



 
 

 <tbody>

  <tr>
    <th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">67</font></th>
    <td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">        <span class="s">&quot;Query&quot;</span> <span class="p">:</span> <span class="s">&quot;SELECT * FROM <span class="hl">CIM_</span>InstModification WHERE &quot;</span></pre></td>
    <th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">67</font></th>
    <td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">        <span class="s">&quot;Query&quot;</span> <span class="p">:</span> <span class="s">&quot;SELECT * FROM <span class="hl">LMI_Software</span>InstModification WHERE &quot;</span></pre></td>
  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is not the shared JobManager. But one specific to software providers.

But it&#39;s true, that these filters should be shared in one place (openlmi.common.JobManager). I&#39;ll modify the patch to use filters from there.</pre>
</div>
<br />



<p>- Michal</p>


<br />
<p>On April 19th, 2013, 3:01 p.m. UTC, Michal Minar wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://reviewboard-openlmi.rhcloud.com/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for OpenLMI Developers.</div>
<div>By Michal Minar.</div>


<p style="color: grey;"><i>Updated April 19, 2013, 3:01 p.m.</i></p>









<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
openlmi-providers
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">modified indication filters

Indication filters now reflect the name of indication class, which is
instrumented by particular provider. This ensures, that cimom knows,
which provider to call and does not bother the others. So instead of
selecting indication instances from general class CIM_InstModification,
it will be LMI_SoftwareInstModification. This is a common pattern for
indication queries.

Avoided another shortcoming of sfcbmof parser:
  /* comment */ something useful is also ignored :-(
</pre>
  </td>
 </tr>
</table>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>mof/70_LMI_SoftwareIndicationFilters.mof <span style="color: grey">(e3af599dbd921ab0224154008aed04027a805a32)</span></li>

 <li>src/python/openlmi/common/IndicationManager.py <span style="color: grey">(b51737386ab05c156fa72ee3e55b0dc137811023)</span></li>

 <li>src/software/openlmi/software/yumdb/jobmanager.py <span style="color: grey">(7283d054028b29c0e101a6b0515b42bc3a550317)</span></li>

</ul>

<p><a href="http://reviewboard-openlmi.rhcloud.com/r/241/diff/" style="margin-left: 3em;">View Diff</a></p>







  </td>
 </tr>
</table>








  </div>
 </body>
</html>