<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://reviewboard-openlmi.rhcloud.com/r/148/">http://reviewboard-openlmi.rhcloud.com/r/148/</a>
     </td>
    </tr>
   </table>
   <br />



<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray solid;">
 <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been discarded.</h1>
  </td>
 </tr>
</table>
<br />


<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://reviewboard-openlmi.rhcloud.com/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for OpenLMI Developers.</div>
<div>By Radek Novacek.</div>


<p style="color: grey;"><i>Updated April 19, 2013, 2:43 p.m.</i></p>









<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
openlmi-networking
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Rework setting creation methods

Methods CreateStaticSetting, CreateDHCPSetting and CreateSlaveSetting was
renamed to CreateOrModifyStaticSetting, CreateOrModifyDynamicSetting and
CreateOrModifySlaveSetting.

All of them now can be used to modify existing setting when SettingData
input argument is supplied.

CreateOrModifyStaticSetting now supports multiple IP addresses,
netmasks/prefixes and gateways -- it&#39;s more aligned with
ExtendedStaticIPAssignmentSettingData class.
</pre>
  </td>
 </tr>
</table>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>mof/LMI_Networking.mof <span style="color: grey">(fb9580105931ba03d1895279d9af561a0e5c5b46)</span></li>

 <li>src/LMI_IPAssignmentSettingDataProvider.c <span style="color: grey">(c3b632c49378233432945cbb8bd3f215425b96ae)</span></li>

 <li>src/LMI_IPConfigurationServiceProvider.c <span style="color: grey">(14af9e65aa0948955a551ac1edce1f5262a28588)</span></li>

 <li>src/connection.h <span style="color: grey">(668460a76d97e0195e53804c29f631b095df2782)</span></li>

 <li>src/connection.c <span style="color: grey">(7678cab5785e6b95edef103dbf3a3fa5f0612efd)</span></li>

 <li>src/connection_nm.c <span style="color: grey">(a0b92223c0bc1a18a29d7bf3342cf5423c835c7f)</span></li>

 <li>src/setting.h <span style="color: grey">(514e7f0469085e73d3293a060752a0193816d9fd)</span></li>

 <li>src/setting.c <span style="color: grey">(25fa7cbad6e8d52359d0142c7210fa8e6a9d5d71)</span></li>

 <li>test/test_apply_connection.py <span style="color: grey">(887cf7825a316ffc437eae650cb55afff02c7b0d)</span></li>

 <li>test/test_create_destroy_connection.py <span style="color: grey">(b278d6acfbb509a8398926f3d6106a92adbe1dcc)</span></li>

 <li>test/test_enable_disable_iface.py <span style="color: grey">(792d3ade8a854ecea38b70ac7d73e157f59f0e53)</span></li>

 <li>test/test_modify_connection.py <span style="color: grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="http://reviewboard-openlmi.rhcloud.com/r/148/diff/" style="margin-left: 3em;">View Diff</a></p>







  </td>
 </tr>
</table>




  </div>
 </body>
</html>