<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard-openlmi.rhcloud.com/r/195/">http://reviewboard-openlmi.rhcloud.com/r/195/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Apart from the issues found, the code looks ok. Still, I would appreciate if someone else looks at it and add another +1.</pre>
<br />
<p>- Jan</p>
<br />
<p>On April 15th, 2013, 7:02 p.m. CEST, Peter Schiffer wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://reviewboard-openlmi.rhcloud.com/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for OpenLMI Developers.</div>
<div>By Peter Schiffer.</div>
<p style="color: grey;"><i>Updated April 15, 2013, 7:02 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
openlmi-providers
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hardware: Added System Memory Provider
Added new provider:
* LMI_MemoryProvider</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>mof/LMI_Hardware.mof <span style="color: grey">(0964291c81b029d17d4945f9faead08e11005ff7)</span></li>
<li>src/hardware/CMakeLists.txt <span style="color: grey">(3949a8ad704581f5d0e9a88ac5fa369511a041ee)</span></li>
<li>src/hardware/LMI_Hardware.h <span style="color: grey">(1f30be648ec59f02a4d4ad67aea4a9c6a958d216)</span></li>
<li>src/hardware/LMI_MemoryProvider.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/hardware/LMI_ProcessorCacheMemoryProvider.c <span style="color: grey">(afc5d7f0488c506dddabd438f7af56578f464856)</span></li>
<li>src/hardware/LMI_ProcessorProvider.c <span style="color: grey">(99b0fad7d1e36efbb1e823d20cda74bf9b577235)</span></li>
<li>src/hardware/cpuinfo.h <span style="color: grey">(5ec5dd5083fe73548a434a3312c0a371c0c0d961)</span></li>
<li>src/hardware/cpuinfo.c <span style="color: grey">(6634b059df7d858654c862e88a705bbc574edef0)</span></li>
<li>src/hardware/dmidecode.h <span style="color: grey">(9190ea4ac26e82889b24184fc40072f007f9c836)</span></li>
<li>src/hardware/dmidecode.c <span style="color: grey">(348c7a23b76f42ab5dae78a86e42c69789a4e021)</span></li>
<li>src/hardware/procfs.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/hardware/procfs.c <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://reviewboard-openlmi.rhcloud.com/r/195/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>