<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://reviewboard-openlmi.rhcloud.com/r/100/">http://reviewboard-openlmi.rhcloud.com/r/100/</a>
     </td>
    </tr>
   </table>
   <br />





 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The same opinion, see https://reviewboard-openlmi.rhcloud.com/r/99/</pre>
 <br />









<p>- Peter</p>


<br />
<p>On April 8th, 2013, 3:34 p.m. UTC, Stephen Gallagher wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://reviewboard-openlmi.rhcloud.com/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for OpenLMI Developers.</div>
<div>By Stephen Gallagher.</div>


<p style="color: grey;"><i>Updated April 8, 2013, 3:34 p.m.</i></p>









<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
openlmi-tools
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The openlmi-tools are built entirely in Python. It seems wasteful to use the heavyweight autotools build system for it. This patch and the one in review https://reviewboard-openlmi.rhcloud.com/r/99/ will replace the autotools build system with one based on Python&#39;s setuptools.

Apologies for the ugly in-browser diff. Apparently, ReviewBoard does not handle file moves very gracefully yet. I&#39;ve attached a different version of the diff as well, which only shows that a move happens and then the differences made. It&#39;s easier to spot that way.</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ran &#39;python setup.py install --root `pwd`/chroot&#39; and verified that all files are installed where expected on the target system.</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>cli-tools/lmi/__init__.py <span style="color: grey">(e69de29bb2d1d6434b8b29ae775ad8c2e48c5391)</span></li>

 <li>cli-tools/lmi/lmi_address.py <span style="color: grey">(140dd269fef10350500c1e3fb0579ef2a46d4063)</span></li>

 <li>cli-tools/lmi/lmi_client_base.py <span style="color: grey">(a69cdfef704e34f8761eecbaa52497920935a6bb)</span></li>

 <li>cli-tools/lmi/lmi_client_ip.py <span style="color: grey">(c5bbaf79a086f674cc477cebcc1103468b91413b)</span></li>

 <li>cli-tools/lmi/lmi_client_power.py <span style="color: grey">(6f625cb011cfa67f8da8979422498d243f806107)</span></li>

 <li>cli-tools/lmi/lmi_client_service.py <span style="color: grey">(d112a87abc54c6ca218af6dfa25556cb6ef05316)</span></li>

 <li>cli-tools/lmi/lmi_client_shell.py <span style="color: grey">(fb3a29e1be1411fc2917391768c58a6865508c6b)</span></li>

 <li>cli-tools/lmi/lmi_client_user.py <span style="color: grey">(aca205b91f1cfe032c2d6d7e899d908799261227)</span></li>

 <li>cli-tools/lmi/lmi_listener.py <span style="color: grey">(6670b204a84485b6e1f8bef5dfa2893098f0a9da)</span></li>

 <li>cli-tools/lmi/lmi_options.py <span style="color: grey">(9fe18761e0b25d99c39cd3a40399bbaa243fee96)</span></li>

 <li>cli-tools/lmiip <span style="color: grey">(200f0df48c3db46618a5b604c0a3fbc08f5f6490)</span></li>

 <li>cli-tools/lmipower <span style="color: grey">(1cf95a5af099b4b0e6fb461383c80be1041e9a8e)</span></li>

 <li>cli-tools/lmiservice <span style="color: grey">(9d4020eb4d51e3a94ba29d2dcd128c1c1cbeb957)</span></li>

 <li>cli-tools/lmishell <span style="color: grey">(89844d862922a3288a461e34838e3194ccf4a97b)</span></li>

 <li>cli-tools/lmiuser <span style="color: grey">(2ecff093adb46c9bbebf776fd846524c7a0185e6)</span></li>

 <li>lmi/lmi_address.py <span style="color: grey">(PRE-CREATION)</span></li>

 <li>lmi/lmi_client_base.py <span style="color: grey">(PRE-CREATION)</span></li>

 <li>lmi/lmi_client_ip.py <span style="color: grey">(PRE-CREATION)</span></li>

 <li>lmi/lmi_client_power.py <span style="color: grey">(PRE-CREATION)</span></li>

 <li>lmi/lmi_client_service.py <span style="color: grey">(PRE-CREATION)</span></li>

 <li>lmi/lmi_client_shell.py <span style="color: grey">(PRE-CREATION)</span></li>

 <li>lmi/lmi_client_user.py <span style="color: grey">(PRE-CREATION)</span></li>

 <li>lmi/lmi_ip.py <span style="color: grey">(PRE-CREATION)</span></li>

 <li>lmi/lmi_listener.py <span style="color: grey">(PRE-CREATION)</span></li>

 <li>lmi/lmi_options.py <span style="color: grey">(PRE-CREATION)</span></li>

 <li>lmi/lmi_power.py <span style="color: grey">(PRE-CREATION)</span></li>

 <li>lmi/lmi_service.py <span style="color: grey">(PRE-CREATION)</span></li>

 <li>lmi/lmi_shell.py <span style="color: grey">(PRE-CREATION)</span></li>

 <li>lmi/lmi_user.py <span style="color: grey">(PRE-CREATION)</span></li>

 <li>setup.py <span style="color: grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="http://reviewboard-openlmi.rhcloud.com/r/100/diff/" style="margin-left: 3em;">View Diff</a></p>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>

<ul>

 <li><a href="http://reviewboard-openlmi.rhcloud.com/static/media/uploaded/files/2013/04/04/0002-Enable-building-openlmi-tools-with-setuptools.patch">Easier-to-read diff</a></li>

</ul>





  </td>
 </tr>
</table>








  </div>
 </body>
</html>