<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard-openlmi.rhcloud.com/r/151/">http://reviewboard-openlmi.rhcloud.com/r/151/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://reviewboard-openlmi.rhcloud.com/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for OpenLMI Developers.</div>
<div>By Peter Schiffer.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
openlmi-providers
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hardware: Code clean up
* Got rid of asprintf() where suitable (used static memory instead)
* Removed if condition before free()
* Replaced more hard coded numbers with LMI constants</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/hardware/LMI_ProcessorCacheMemoryProvider.c <span style="color: grey">(d4c73f65bee82e26b8b09a9f5ed3bc22945d762a)</span></li>
<li>src/hardware/LMI_Hardware.h <span style="color: grey">(16bdf122e2f5b611b45c7a508726b3a09808c8d4)</span></li>
<li>src/hardware/LMI_AssociatedProcessorCacheMemoryProvider.c <span style="color: grey">(b06aa223d4e954d51abf2431c3a0a6247283b648)</span></li>
<li>src/hardware/LMI_ProcessorCapabilitiesProvider.c <span style="color: grey">(c7c4ff250d89e2c115cbbda8a54845213fccb770)</span></li>
<li>src/hardware/LMI_ProcessorElementCapabilitiesProvider.c <span style="color: grey">(ee9cf18a33f2ebe3784b8e5c53c6e28769b1871f)</span></li>
<li>src/hardware/LMI_ProcessorProvider.c <span style="color: grey">(6280bbd60d732433870ebc539146006daf2fa126)</span></li>
<li>src/hardware/cpuinfo.c <span style="color: grey">(d80e1cb5890cd1c72fff7c257cb4f042dd50b06d)</span></li>
<li>src/hardware/dmidecode.c <span style="color: grey">(a50aa8a19ae0fc3acc6979484cdff2dc1cdff0a9)</span></li>
<li>src/hardware/lscpu.c <span style="color: grey">(d4546cb42a401c4b6d79bc9e13990d94c463d282)</span></li>
<li>src/hardware/sysfs.c <span style="color: grey">(c2cc1affeabf0329ca32e1d9956eaf468b0a56d1)</span></li>
<li>src/hardware/utils.h <span style="color: grey">(9f5686faf4e50775b18adb62bfd0f5a707f093cb)</span></li>
<li>src/hardware/utils.c <span style="color: grey">(da7bbfadffd77afd5ecc1c81360cb7f23f3412e1)</span></li>
</ul>
<p><a href="http://reviewboard-openlmi.rhcloud.com/r/151/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>