<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard-openlmi.rhcloud.com/r/56/">http://reviewboard-openlmi.rhcloud.com/r/56/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 26th, 2013, 8:50 a.m. UTC, <b>Roman Rakus</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://reviewboard-openlmi.rhcloud.com/r/56/diff/1/?file=223#file223line42" style="color: black; font-weight: bold; text-decoration: underline;">src/hardware/LMI_ProcessorCapabilitiesProvider.c</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">42</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="o">*</span><span class="n">instace_id_string</span> <span class="o">=</span> <span class="s">"LMI:ProcessorCapabilities:"</span><span class="p">,</span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">43</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="o">*</span><span class="n">element_name_string</span> <span class="o">=</span> <span class="s">"Capabilities of processor "</span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Isn't better to move these constants to some header file as macros?</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">And split it to parts. ORGID, CLASSNAME or so. And ORGID will be global for all providers.</pre>
<br />
<p>- Roman</p>
<br />
<p>On March 25th, 2013, 4:24 p.m. UTC, Peter Schiffer wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://reviewboard-openlmi.rhcloud.com/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for OpenLMI Developers.</div>
<div>By Peter Schiffer.</div>
<p style="color: grey;"><i>Updated March 25, 2013, 4:24 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
openlmi-providers
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hardware: added new providers
Providers added:
* LMI_ProcessorCapabilitiesProvider
* LMI_ProcessorElementCapabilitiesProvider</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>mof/LMI_Hardware.mof <span style="color: grey">(4848ef1dbc40f5e01d496dcc893ac389d62aaa4f)</span></li>
<li>src/hardware/CMakeLists.txt <span style="color: grey">(ebf79fb40869125ccb72dcd77a03038fa7066809)</span></li>
<li>src/hardware/LMI_ProcessorCapabilitiesProvider.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/hardware/LMI_ProcessorElementCapabilitiesProvider.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/hardware/LMI_ProcessorProvider.c <span style="color: grey">(8e92fdd3ad0efc86287c19e93509559d3ed2cd49)</span></li>
<li>src/hardware/dmidecode.h <span style="color: grey">(f7e76a929bf19c481278a59c81e20a64201f75a7)</span></li>
<li>src/hardware/dmidecode.c <span style="color: grey">(6a038fbe6a8b9acefbc1facafa2ee6a2195a0788)</span></li>
<li>src/hardware/lscpu.h <span style="color: grey">(892141e2ff423ebc004091c8982565880b51265c)</span></li>
<li>src/hardware/lscpu.c <span style="color: grey">(124ed7b81121ed9f2aabac4a7c2d49f7c65282e0)</span></li>
<li>src/hardware/utils.h <span style="color: grey">(9f5686faf4e50775b18adb62bfd0f5a707f093cb)</span></li>
<li>src/hardware/utils.c <span style="color: grey">(da7bbfadffd77afd5ecc1c81360cb7f23f3412e1)</span></li>
</ul>
<p><a href="http://reviewboard-openlmi.rhcloud.com/r/56/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>