Review Request 869: openlmi-providers [1/4] Improve logging in C providers

Michal Minar reviewboard at gallagherhome.com
Wed Sep 18 12:09:51 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/869/#review1195
-----------------------------------------------------------



src/openlmi.c
<http://reviewboard-openlmi.rhcloud.com/r/869/#comment740>

    Please could you modify this, so that "1", "yes", "true", and "on" are also accepted?
    So it's compatible with ConfigParser from python: file:///usr/share/doc/python-docs-2.7.3/html/library/configparser.html#ConfigParser.RawConfigParser.getboolean
    
    IMHO some convenient function like
    lme_read_config_boolean(..) might prove useful.


- Michal Minar


On Sept. 18, 2013, 6:08 a.m., Radek Novacek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-openlmi.rhcloud.com/r/869/
> -----------------------------------------------------------
> 
> (Updated Sept. 18, 2013, 6:08 a.m.)
> 
> 
> Review request for OpenLMI Developers.
> 
> 
> Repository: openlmi-providers
> 
> 
> Description
> -------
> 
> Improve logging in C providers
> 
> Use CMLogMessage instead of CMTraceMessage for each message with level
> > ERROR.
> 
> The logging level is now read from the config file.
> 
> The Stderr option for logging to stderr in now also honored.
> 
> 
> Diffs
> -----
> 
>   src/openlmi.h 93778ce71109a0d230ea427f905215ac485ed04c 
>   src/openlmi.c ac539bdb55150ca030db24d08362be17b0a2016b 
> 
> Diff: http://reviewboard-openlmi.rhcloud.com/r/869/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Radek Novacek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.fedorahosted.org/pipermail/openlmi-devel/attachments/20130918/47044a27/attachment.html>
-------------- next part --------------
_______________________________________________
openlmi-reviews mailing list
openlmi-reviews at lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/openlmi-reviews


More information about the openlmi-devel mailing list