openlmi-reviews Digest, Vol 1, Issue 1

openlmi-reviews-request at lists.fedorahosted.org openlmi-reviews-request at lists.fedorahosted.org
Thu May 30 07:55:00 UTC 2013


Send openlmi-reviews mailing list submissions to
	openlmi-reviews at lists.fedorahosted.org

To subscribe or unsubscribe via the World Wide Web, visit
	https://lists.fedorahosted.org/mailman/listinfo/openlmi-reviews
or, via email, send a message with subject or body 'help' to
	openlmi-reviews-request at lists.fedorahosted.org

You can reach the person managing the list at
	openlmi-reviews-owner at lists.fedorahosted.org

When replying, please edit your Subject line so it is more specific
than "Re: Contents of openlmi-reviews digest..."


Today's Topics:

   1. Re: Review Request 417: Account [1/1] Account: Correctly
      handle empty	fields in shadow file (Stephen Gallagher)
   2. Re: Review Request 423: [1/1] Add mounting documentation for
      admins. (Jan Safranek)
   3. Re: Review Request 418: openlmi-networking [1/4] Implement
      NetworkAddresses and MaxSpeed properties of LMI_EthernetPort
      (Jan Safranek)


----------------------------------------------------------------------

Message: 1
Date: Wed, 29 May 2013 19:37:41 -0000
From: Stephen Gallagher <reviewboard at gallagherhome.com>
To: "OpenLMI Developers" <openlmi-reviews at lists.fedorahosted.org>,
	"Stephen Gallagher" <sgallagh at fedoraproject.org>,	"Roman Rakus"
	<rrakus at redhat.com>
Subject: Re: Review Request 417: Account [1/1] Account: Correctly
	handle empty	fields in shadow file
Message-ID:
	<20130529193741.11235.9372 at ex-std-node147.prod.rhcloud.com>
Content-Type: text/plain; charset="utf-8"


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/417/#review499
-----------------------------------------------------------



src/account/LMI_AccountProvider.c
<http://reviewboard-openlmi.rhcloud.com/r/417/#comment302>

    Could you create a macro definition for -1 instead of using magic numbers? That way it's clear what you're testing for. Something like
    
    #define SHADOW_VALUE_EMPTY -1


- Stephen Gallagher


On May 28, 2013, 2:42 p.m., Roman Rakus wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-openlmi.rhcloud.com/r/417/
> -----------------------------------------------------------
> 
> (Updated May 28, 2013, 2:42 p.m.)
> 
> 
> Review request for OpenLMI Developers.
> 
> 
> Repository: openlmi-providers
> 
> 
> Description
> -------
> 
> Account: Correctly handle empty fields in shadow file
> 
> libuser returns -1 for empty fields. Handle the -1 on missing places.
> 
> Fixes Ticket #113: LMI_Account instance enumeration fails with "DateTime is out of range"
> 
> Signed-off-by: Roman Rakus <rrakus at redhat.com>
> 
> 
> Diffs
> -----
> 
>   src/account/LMI_AccountProvider.c c4a68f7c71d0f77821bdf95aec7ae60ffae0b455 
> 
> Diff: http://reviewboard-openlmi.rhcloud.com/r/417/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Roman Rakus
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.fedorahosted.org/pipermail/openlmi-reviews/attachments/20130529/b9bd7ee1/attachment-0001.html>

------------------------------

Message: 2
Date: Thu, 30 May 2013 07:39:56 -0000
From: Jan Safranek <reviewboard at gallagherhome.com>
To: "OpenLMI Developers" <openlmi-reviews at lists.fedorahosted.org>,
	"Jan Safranek" <jsafrane at redhat.com>, "Jan Synacek"
	<jsynacek at redhat.com>
Subject: Re: Review Request 423: [1/1] Add mounting documentation for
	admins.
Message-ID:
	<20130530073956.11235.40789 at ex-std-node147.prod.rhcloud.com>
Content-Type: text/plain; charset="utf-8"


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/423/#review500
-----------------------------------------------------------

Ship it!



doc/admin/usage-mounting.rst
<http://reviewboard-openlmi.rhcloud.com/r/423/#comment303>

    typo: persistent


- Jan Safranek


On May 29, 2013, 3:35 p.m., Jan Synacek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-openlmi.rhcloud.com/r/423/
> -----------------------------------------------------------
> 
> (Updated May 29, 2013, 3:35 p.m.)
> 
> 
> Review request for OpenLMI Developers.
> 
> 
> Repository: openlmi-storage
> 
> 
> Description
> -------
> 
> Add mounting documentation for admins.
> 
> 
> Diffs
> -----
> 
>   doc/admin/Makefile 630076a43c797d4ce70e50f48a9e7dc75a147bbb 
>   doc/admin/mof/Makefile 3d06e26c7eb58c2285b412975b0451409c130b86 
>   doc/admin/pic/mounting-instance-2.uml PRE-CREATION 
>   doc/admin/pic/mounting-instance-3.uml PRE-CREATION 
>   doc/admin/pic/mounting-instance.uml PRE-CREATION 
>   doc/admin/usage-mounting.rst PRE-CREATION 
>   doc/admin/usage.rst 7d9df4ef87df9a9865d510a568a369e6eb7157fd 
> 
> Diff: http://reviewboard-openlmi.rhcloud.com/r/423/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jan Synacek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.fedorahosted.org/pipermail/openlmi-reviews/attachments/20130530/17b1f0a1/attachment-0001.html>

------------------------------

Message: 3
Date: Thu, 30 May 2013 07:54:56 -0000
From: Jan Safranek <reviewboard at gallagherhome.com>
To: "OpenLMI Developers" <openlmi-reviews at lists.fedorahosted.org>,
	"Jan Safranek" <jsafrane at redhat.com>, "Radek Novacek"
	<rnovacek at redhat.com>
Subject: Re: Review Request 418: openlmi-networking [1/4] Implement
	NetworkAddresses and MaxSpeed properties of LMI_EthernetPort
Message-ID:
	<20130530075456.11235.11427 at ex-std-node147.prod.rhcloud.com>
Content-Type: text/plain; charset="utf-8"


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/418/#review501
-----------------------------------------------------------

Ship it!


Ship It!

- Jan Safranek


On May 29, 2013, 12:55 p.m., Radek Novacek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-openlmi.rhcloud.com/r/418/
> -----------------------------------------------------------
> 
> (Updated May 29, 2013, 12:55 p.m.)
> 
> 
> Review request for OpenLMI Developers.
> 
> 
> Repository: openlmi-networking
> 
> 
> Description
> -------
> 
> Implement NetworkAddresses and MaxSpeed properties of LMI_EthernetPort
> 
> 
> Diffs
> -----
> 
>   mof/LMI_Networking.mof d03d6e1c06c5fe2f17711816ab29c1cef4e91c88 
>   src/LMI_EthernetPortProvider.c 78df2e0f10b478984a5d13dcd020377bd6283603 
>   src/port.h 8558a4e2752f3f12972514d9bae803d03949a201 
>   src/port.c 3d69058c197142bb257d3f6ed6706c44f67b1f02 
>   src/port_nm.c 70f5453fda21bf886451c460f15795588caf9fc4 
>   src/port_private.h fc27956d8d475df355072751d007a3b0dc91534c 
> 
> Diff: http://reviewboard-openlmi.rhcloud.com/r/418/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Radek Novacek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.fedorahosted.org/pipermail/openlmi-reviews/attachments/20130530/27795691/attachment.html>

------------------------------

_______________________________________________
openlmi-reviews mailing list
openlmi-reviews at lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/openlmi-reviews


End of openlmi-reviews Digest, Vol 1, Issue 1
*********************************************


More information about the openlmi-devel mailing list