Review Request 384: Storage MOF file cleanup: [3/3] Added description to undocumented mounting classes.

Jan Safranek reviewboard at gallagherhome.com
Wed May 22 14:07:45 UTC 2013



> On May 22, 2013, 1:04 p.m., Jan Synacek wrote:
> > I can't view the patch in via Review Board, so I downloaded it and will try to review it like this...
> > 
> > Line 46: "If IsNew property of this association" ... 
> > IsNew -> IsNext
> > 
> > Line 81-81:  "This association connects LMI_MountedFileSystem to CIM_FileSystem which "
> >              "is mounted."
> > I would reword the sentence a bit. IMHO it is a bit unclear.

"This association connects LMI_MountedFileSystem to the mounted CIM_FileSystem" ?


- Jan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/384/#review448
-----------------------------------------------------------


On May 22, 2013, 10:30 a.m., Jan Safranek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-openlmi.rhcloud.com/r/384/
> -----------------------------------------------------------
> 
> (Updated May 22, 2013, 10:30 a.m.)
> 
> 
> Review request for OpenLMI Developers.
> 
> 
> Repository: openlmi-storage
> 
> 
> Description
> -------
> 
> Added description to undocumented mounting classes.
> 
> 
> Diffs
> -----
> 
>   mof/LMI_Storage-Mounting.mof bd39af4bbca02a4d1982b0c323d6bdacc8cb9b6b 
> 
> Diff: http://reviewboard-openlmi.rhcloud.com/r/384/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jan Safranek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.fedorahosted.org/pipermail/openlmi-devel/attachments/20130522/a5a4f572/attachment.html>


More information about the openlmi-devel mailing list