Review Request 377: openlmi-networking <bonding> [3/7] Add LMI_CreateSlaveSetting method

Radek Novacek reviewboard at gallagherhome.com
Wed May 22 14:02:21 UTC 2013



> On May 22, 2013, 3:55 p.m., Jan Safranek wrote:
> > src/LMI_IPNetworkConnectionCapabilitiesProvider.c, line 271
> > <http://reviewboard-openlmi.rhcloud.com/r/377/diff/1/?file=2314#file2314line271>
> >
> >     I'm not sure, you free the connection also when the function returns successfully, is it intended?

Yes, network_create_connection calls NetworkManager via D-Bus and NM emits signal that the connection is created. This connection might be different than requested connection (implicit values are supplied).


> On May 22, 2013, 3:55 p.m., Jan Safranek wrote:
> > src/LMI_IPNetworkConnectionCapabilitiesProvider.c, line 557
> > <http://reviewboard-openlmi.rhcloud.com/r/377/diff/1/?file=2314#file2314line557>
> >
> >     Not sure, can connections_find_by_id fail?

Yes, will add the error check.


> On May 22, 2013, 3:55 p.m., Jan Safranek wrote:
> > src/LMI_IPNetworkConnectionCapabilitiesProvider.c, line 561
> > <http://reviewboard-openlmi.rhcloud.com/r/377/diff/1/?file=2314#file2314line561>
> >
> >     Missing error check, enslave can fail.

Will add.


- Radek


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/377/#review459
-----------------------------------------------------------


On May 20, 2013, 3:39 p.m., Radek Novacek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-openlmi.rhcloud.com/r/377/
> -----------------------------------------------------------
> 
> (Updated May 20, 2013, 3:39 p.m.)
> 
> 
> Review request for OpenLMI Developers.
> 
> 
> Repository: openlmi-networking
> 
> 
> Description
> -------
> 
> Add LMI_CreateSlaveSetting method
> 
> This method creates new slave setting for given master setting. It can
> be used for enslaving device to bond/bridge connection.
> 
> 
> Diffs
> -----
> 
>   mof/LMI_Networking.mof ba0de083aca4e898d09bdbb8c8920e7de040f10a 
>   src/LMI_IPNetworkConnectionCapabilitiesProvider.c 38993a656ee181b7adb71a7485a1f11e5a6509be 
> 
> Diff: http://reviewboard-openlmi.rhcloud.com/r/377/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Radek Novacek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.fedorahosted.org/pipermail/openlmi-devel/attachments/20130522/d2bd9862/attachment-0001.html>


More information about the openlmi-devel mailing list