Review Request 360: openlmi-providers: Add method to stop the running thread to all Managers.

Radek Novacek reviewboard at gallagherhome.com
Thu May 16 09:09:11 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/360/#review422
-----------------------------------------------------------

Ship it!



src/python/openlmi/common/JobManager.py
<http://reviewboard-openlmi.rhcloud.com/r/360/#comment277>

    Wouldn't it be better to share this enumeration with IndicationManager.py?



src/python/openlmi/common/JobManager.py
<http://reviewboard-openlmi.rhcloud.com/r/360/#comment279>

    Value of variable 'command' should be checked if it's really COMMAND_STOP


- Radek Novacek


On May 16, 2013, 10:41 a.m., Jan Safranek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-openlmi.rhcloud.com/r/360/
> -----------------------------------------------------------
> 
> (Updated May 16, 2013, 10:41 a.m.)
> 
> 
> Review request for OpenLMI Developers.
> 
> 
> Repository: openlmi-providers
> 
> 
> Description
> -------
> 
> Add method to stop the running thread to all Managers.
> 
> We should cleanly shut down all threads when the provider is unloaded,
> just to be nice to CIMOMs.
> 
> 
> Diffs
> -----
> 
>   src/python/openlmi/common/IndicationManager.py a17703f8d2dfea46324a0e4bb0365c2df38636ab 
>   src/python/openlmi/common/JobManager.py fc12d7efaec004439b67e47541fa095e94e0deb5 
>   src/python/openlmi/common/TimerManager.py 5eb39ae53e1ffe8b1f8c318481d391fbe5ce1235 
> 
> Diff: http://reviewboard-openlmi.rhcloud.com/r/360/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jan Safranek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.fedorahosted.org/pipermail/openlmi-devel/attachments/20130516/2b6ea98b/attachment-0001.html>


More information about the openlmi-devel mailing list