Review Request 359: openlmi-providers [4/4] Add ReturnInstance macro to be used instead of KReturnInstance
Jan Safranek
reviewboard at gallagherhome.com
Thu May 16 08:36:30 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/359/#review419
-----------------------------------------------------------
Ship it!
Ship It!
- Jan Safranek
On May 16, 2013, 10:29 a.m., Radek Novacek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-openlmi.rhcloud.com/r/359/
> -----------------------------------------------------------
>
> (Updated May 16, 2013, 10:29 a.m.)
>
>
> Review request for OpenLMI Developers.
>
>
> Repository: openlmi-providers
>
>
> Description
> -------
>
> Add ReturnInstance macro to be used instead of KReturnInstance
>
> KReturnInstance macro calls return directly on failure which is bad
> because there is no possibility to do cleanups or other error handling.
>
> ReturnInstance macro returns plain boolean to indicate if the instance
> is returned properly.
>
>
> Diffs
> -----
>
> src/openlmi.h 9b27d0744db1aab8533f42e63b24e32316f69a80
>
> Diff: http://reviewboard-openlmi.rhcloud.com/r/359/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Radek Novacek
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.fedorahosted.org/pipermail/openlmi-devel/attachments/20130516/3ca2d370/attachment.html>
More information about the openlmi-devel
mailing list