Review Request 359: openlmi-providers [4/4] Add ReturnInstance macro to be used instead of KReturnInstance

Jan Safranek reviewboard at gallagherhome.com
Thu May 16 08:23:47 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/359/#review415
-----------------------------------------------------------



src/openlmi.h
<http://reviewboard-openlmi.rhcloud.com/r/359/#comment273>

    IMHO there should be some prefix so the macro does not conflict with any other function/macro, who knows what 3rd party providers will use.


- Jan Safranek


On May 16, 2013, 10:01 a.m., Radek Novacek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-openlmi.rhcloud.com/r/359/
> -----------------------------------------------------------
> 
> (Updated May 16, 2013, 10:01 a.m.)
> 
> 
> Review request for OpenLMI Developers.
> 
> 
> Repository: openlmi-providers
> 
> 
> Description
> -------
> 
> Add ReturnInstance macro to be used instead of KReturnInstance
> 
> KReturnInstance macro calls return directly on failure which is bad
> because there is no possibility to do cleanups or other error handling.
> 
> ReturnInstance macro returns plain boolean to indicate if the instance
> is returned properly.
> 
> 
> Diffs
> -----
> 
>   src/openlmi.h 9b27d0744db1aab8533f42e63b24e32316f69a80 
> 
> Diff: http://reviewboard-openlmi.rhcloud.com/r/359/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Radek Novacek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.fedorahosted.org/pipermail/openlmi-devel/attachments/20130516/ca71482b/attachment-0001.html>


More information about the openlmi-devel mailing list