Review Request 335: openlmi-software[verification] [6/9] delete YumDB singleton in YumWorker process
Jan Safranek
reviewboard at gallagherhome.com
Fri May 10 14:59:51 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/335/#review395
-----------------------------------------------------------
src/software/openlmi/software/yumdb/process.py
<http://reviewboard-openlmi.rhcloud.com/r/335/#comment245>
That's very poor detection of process. IMHO it's hackish and even global variable would be cleaner.
- Jan Safranek
On May 10, 2013, 4:27 p.m., Michal Minar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-openlmi.rhcloud.com/r/335/
> -----------------------------------------------------------
>
> (Updated May 10, 2013, 4:27 p.m.)
>
>
> Review request for OpenLMI Developers.
>
>
> Repository: openlmi-providers
>
>
> Description
> -------
>
> delete YumDB singleton in YumWorker process
>
> YumDB singleton launches YumWorker process and then serves as
> its interface. We don't need its instance in separate process.
> Deleting it allows us to check, whether we run under broker process
> or under YumWorker.
>
>
> Diffs
> -----
>
> src/software/openlmi/software/yumdb/process.py 8ae6e46b0f5f9615afaa9654afa2316f99fc02b6
>
> Diff: http://reviewboard-openlmi.rhcloud.com/r/335/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Michal Minar
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.fedorahosted.org/pipermail/openlmi-devel/attachments/20130510/99100e2a/attachment.html>
More information about the openlmi-devel
mailing list