Review Request 305: openlmi-networking [3/3] Add support for static routes
Jan Safranek
reviewboard at gallagherhome.com
Fri May 10 08:57:48 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/305/#review371
-----------------------------------------------------------
Ship it!
src/LMI_IPAssignmentSettingDataProvider.c
<http://reviewboard-openlmi.rhcloud.com/r/305/#comment234>
What if the clone fails?
src/LMI_IPAssignmentSettingDataProvider.c
<http://reviewboard-openlmi.rhcloud.com/r/305/#comment235>
I don't like the magic numbers '1' and '2'.
src/LMI_IPRouteSettingDataProvider.c
<http://reviewboard-openlmi.rhcloud.com/r/305/#comment236>
What if the instanceid has wrong format and id == NULL?
src/LMI_RouteUsesEndpointProvider.c
<http://reviewboard-openlmi.rhcloud.com/r/305/#comment237>
what if id is NULL?
src/ipassignmentsettingdata.c
<http://reviewboard-openlmi.rhcloud.com/r/305/#comment238>
what if id is NULL?
Apart from some error cases, the code looks fine.
- Jan Safranek
On May 7, 2013, 3:38 p.m., Radek Novacek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-openlmi.rhcloud.com/r/305/
> -----------------------------------------------------------
>
> (Updated May 7, 2013, 3:38 p.m.)
>
>
> Review request for OpenLMI Developers.
>
>
> Repository: openlmi-networking
>
>
> Description
> -------
>
> Add support for static routes
>
>
> Diffs
> -----
>
> mof/LMI_Networking.mof 9b35139587d5da21a53473266433627eafac6350
> src/LMI_IPAssignmentSettingDataProvider.c be1b866f4794d4d72c1784132f68005b3000422f
> src/LMI_IPRouteSettingDataProvider.c PRE-CREATION
> src/LMI_NextHopIPRouteProvider.c PRE-CREATION
> src/LMI_OrderedIPAssignmentComponentProvider.c 1f3ddb92462e07f4bca7a1141a12cba702936cd5
> src/LMI_RouteUsesEndpointProvider.c PRE-CREATION
> src/ipassignmentsettingdata.c 1a9501e04fcf8791b54deb719fd8c3c1d32f4633
> src/port_nm.c d3d123788d673dc40491e58a23001e8d16370ff9
> src/setting.h 1f678c3a6c96fc26184c90089539bfaffc433e3e
> src/setting.c e05ed50ac3b2a13806f6abe032a0e588d81e39c9
> test/test_create_destroy_connection.py 92876050f6a5a238d6c6821934ba3f48e8576e2a
>
> Diff: http://reviewboard-openlmi.rhcloud.com/r/305/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Radek Novacek
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.fedorahosted.org/pipermail/openlmi-devel/attachments/20130510/fea3a8d5/attachment.html>
More information about the openlmi-devel
mailing list