Review Request 300: openlmi-software[+CIM_InstMethodCall] support for method parameters and pre/post indications

Jan Safranek reviewboard at gallagherhome.com
Fri May 10 08:25:12 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/300/#review364
-----------------------------------------------------------



src/software/openlmi/software/core/InstMethodCall.py
<http://reviewboard-openlmi.rhcloud.com/r/300/#comment231>

    Raising TypeError and ValueError is nice and clean, still, what the caller does with these exceptions? IMHO they are translated to CIMError anyway.
    
    And what "job must be a YumJob" tells the user? IMHO these check could be simple assert().
    
    Feel free to keep the code like it is, it is correct and nice, I'm just wondering.


- Jan Safranek


On May 2, 2013, 3:02 p.m., Michal Minar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-openlmi.rhcloud.com/r/300/
> -----------------------------------------------------------
> 
> (Updated May 2, 2013, 3:02 p.m.)
> 
> 
> Review request for OpenLMI Developers.
> 
> 
> Repository: openlmi-providers
> 
> 
> Description
> -------
> 
> support for method parameters and pre/post indications
> 
> Added input and output parameters to LMI_SoftwareInstallationJob.
> Added PreCallIndication and PostCallIndication properties to
> LMI_SoftwareMethodResult containg CIM_InstMethodCall indication
> instances - that are rather useless but mandatory by Job Control
> Profile.
> 
> 
> Diffs
> -----
> 
>   src/software/openlmi/software/yumdb/jobs.py 84fd3ed5f7333d74528fe1b4757844c070906aa8 
>   src/software/openlmi/software/yumdb/__init__.py 04f21918cdce7aae0e7c474992b53a472bf09ec0 
>   src/software/openlmi/software/core/MethodResult.py 723edbba967205f1e5231981fa22559adfcb9c03 
>   src/software/openlmi/software/core/InstallationService.py acc7ca60392f17ba930c74a8b7f07d064ab3b1da 
>   src/software/openlmi/software/core/InstallationJob.py 7b06be2acbab2df92125290759b6552063171f3f 
>   src/software/openlmi/software/core/InstMethodCall.py PRE-CREATION 
>   src/software/openlmi/software/core/Error.py 210c00ef912aca7453437b3eb93f68449684c273 
>   src/software/openlmi/software/LMI_SoftwareInstallationService.py f1e0ea71ec1d132c91ad49d86b3dcf9d5d4be139 
> 
> Diff: http://reviewboard-openlmi.rhcloud.com/r/300/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michal Minar
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.fedorahosted.org/pipermail/openlmi-devel/attachments/20130510/dc4dd26e/attachment.html>


More information about the openlmi-devel mailing list