Review Request 310: Fix redefinition of ORGID in the realmd provider

Radek Novacek reviewboard at gallagherhome.com
Thu May 9 08:18:39 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/310/#review356
-----------------------------------------------------------


Is there any reason why realmd provider don't use "LMI" ORGID as all other providers?

- Radek Novacek


On May 8, 2013, 3:43 p.m., stefw wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-openlmi.rhcloud.com/r/310/
> -----------------------------------------------------------
> 
> (Updated May 8, 2013, 3:43 p.m.)
> 
> 
> Review request for OpenLMI Developers.
> 
> 
> Repository: openlmi-providers
> 
> 
> Description
> -------
> 
> Fix warnings:
> 
> 15:08:34 **** Build of configuration Default for project openlmi-providers ****
> make all 
> [ 11%] Built target openlmicommon
> [ 22%] Building C object src/realmd/CMakeFiles/cmpiLMI_Realmd.dir/LMI_HostedRealmdServiceProvider.c.o
> In file included from /data/projects/openlmi-providers/src/realmd/LMI_HostedRealmdServiceProvider.c:5:0:
> /data/projects/openlmi-providers/src/globals.h:33:0: warning: "ORGID" redefined [enabled by default]
>  #define ORGID "LMI"
>  ^
> In file included from /data/projects/openlmi-providers/src/realmd/LMI_HostedRealmdServiceProvider.c:4:0:
> /data/projects/openlmi-providers/src/realmd/rdcp_util.h:12:0: note: this is the location of the previous definition
>  #define ORGID "LMI_Realmd"
>  ^
> /data/projects/openlmi-providers/src/realmd/LMI_HostedRealmdServiceProvider.c:233:28: warning: ISO C does not allow extra ‘;’ outside of a function [-Wpedantic]
>      "instance association");
>                             ^
> [ 33%] Building C object src/realmd/CMakeFiles/cmpiLMI_Realmd.dir/LMI_RealmdKerberosRealmProvider.c.o
> In file included from /data/projects/openlmi-providers/src/realmd/LMI_RealmdKerberosRealmProvider.c:6:0:
> /data/projects/openlmi-providers/src/realmd/rdcp_util.h:12:0: warning: "ORGID" redefined [enabled by default]
>  #define ORGID "LMI_Realmd"
>  ^
> In file included from /data/projects/openlmi-providers/src/realmd/LMI_RealmdKerberosRealmProvider.c:3:0:
> /data/projects/openlmi-providers/src/globals.h:33:0: note: this is the location of the previous definition
>  #define ORGID "LMI"
>  ^
> /data/projects/openlmi-providers/src/realmd/LMI_RealmdKerberosRealmProvider.c:627:23: warning: ISO C does not allow extra ‘;’ outside of a function [-Wpedantic]
>      "instance method");
>                        ^
> [ 44%] Building C object src/realmd/CMakeFiles/cmpiLMI_Realmd.dir/LMI_RealmdRealmProvider.c.o
> In file included from /data/projects/openlmi-providers/src/realmd/LMI_RealmdRealmProvider.c:7:0:
> /data/projects/openlmi-providers/src/realmd/rdcp_util.h:12:0: warning: "ORGID" redefined [enabled by default]
>  #define ORGID "LMI_Realmd"
>  ^
> In file included from /data/projects/openlmi-providers/src/realmd/LMI_RealmdRealmProvider.c:4:0:
> /data/projects/openlmi-providers/src/globals.h:33:0: note: this is the location of the previous definition
>  #define ORGID "LMI"
>  ^
> /data/projects/openlmi-providers/src/realmd/LMI_RealmdRealmProvider.c:326:23: warning: ISO C does not allow extra ‘;’ outside of a function [-Wpedantic]
>      "instance method");
>                        ^
> [ 55%] Building C object src/realmd/CMakeFiles/cmpiLMI_Realmd.dir/LMI_RealmdServiceProvider.c.o
> In file included from /data/projects/openlmi-providers/src/realmd/LMI_RealmdServiceProvider.c:6:0:
> /data/projects/openlmi-providers/src/realmd/rdcp_util.h:12:0: warning: "ORGID" redefined [enabled by default]
>  #define ORGID "LMI_Realmd"
>  ^
> In file included from /data/projects/openlmi-providers/src/realmd/LMI_RealmdServiceProvider.c:3:0:
> /data/projects/openlmi-providers/src/globals.h:33:0: note: this is the location of the previous definition
>  #define ORGID "LMI"
>  ^
> /data/projects/openlmi-providers/src/realmd/LMI_RealmdServiceProvider.c:631:23: warning: ISO C does not allow extra ‘;’ outside of a function [-Wpedantic]
>      "instance method");
>                        ^
> [ 66%] Building C object src/realmd/CMakeFiles/cmpiLMI_Realmd.dir/LMI_ServiceAffectsRealmdRealmProvider.c.o
> In file included from /data/projects/openlmi-providers/src/realmd/LMI_ServiceAffectsRealmdRealmProvider.c:4:0:
> /data/projects/openlmi-providers/src/globals.h:33:0: warning: "ORGID" redefined [enabled by default]
>  #define ORGID "LMI"
>  ^
> In file included from /data/projects/openlmi-providers/src/realmd/LMI_ServiceAffectsRealmdRealmProvider.c:3:0:
> /data/projects/openlmi-providers/src/realmd/rdcp_util.h:12:0: note: this is the location of the previous definition
>  #define ORGID "LMI_Realmd"
>  ^
> /data/projects/openlmi-providers/src/realmd/LMI_ServiceAffectsRealmdRealmProvider.c:252:28: warning: ISO C does not allow extra ‘;’ outside of a function [-Wpedantic]
>      "instance association");
>                             ^
> [ 77%] Building C object src/realmd/CMakeFiles/cmpiLMI_Realmd.dir/rdcp_dbus.c.o
> /data/projects/openlmi-providers/src/realmd/rdcp_dbus.c:697:1: warning: ‘dbus_method_append_args_tuple’ defined but not used [-Wunused-function]
>  dbus_method_append_args_tuple(DBusMessage  *message, GVariant *args, GError **g_error)
>  ^
> /data/projects/openlmi-providers/src/realmd/rdcp_dbus.c:777:1: warning: ‘marshal_dbus_dict_string_entry’ defined but not used [-Wunused-function]
>  marshal_dbus_dict_string_entry(DBusMessageIter *array, const char *name, const char *value, GError **g_error)
>  ^
> [ 88%] Building C object src/realmd/CMakeFiles/cmpiLMI_Realmd.dir/rdcp_error.c.o
> [100%] Building C object src/realmd/CMakeFiles/cmpiLMI_Realmd.dir/rdcp_util.c.o
> Linking C shared library libcmpiLMI_Realmd.so
> Generating .reg file from library for Realmd
> [100%] Built target cmpiLMI_Realmd
> 
> 15:08:37 Build Finished (took 3s.194ms)
> 
> 
> Diffs
> -----
> 
>   src/globals.h 094602f71ac6ffeb1b0162320227bc8a9f935359 
>   src/realmd/LMI_RealmdKerberosRealmProvider.c 5dc90d2b5faefe264c652d054d4770d57ee02fe4 
>   src/realmd/LMI_RealmdRealmProvider.c d8e0a188f0f822004c4f082fb52730c61479bef1 
>   src/realmd/LMI_RealmdServiceProvider.c 01fc0b839d0cc7267ef623bba9aad14581fc585d 
> 
> Diff: http://reviewboard-openlmi.rhcloud.com/r/310/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> stefw
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.fedorahosted.org/pipermail/openlmi-devel/attachments/20130509/a9394c8d/attachment.html>


More information about the openlmi-devel mailing list