Review Request 56: Hardware: added new providers

Peter Schiffer reviewboard at gallagherhome.com
Tue Mar 26 14:50:34 UTC 2013



> On March 26, 2013, 9:50 a.m., Roman Rakus wrote:
> > src/hardware/LMI_ProcessorCapabilitiesProvider.c, lines 42-43
> > <http://reviewboard-openlmi.rhcloud.com/r/56/diff/1/?file=223#file223line42>
> >
> >     Isn't better to move these constants to some header file as macros?
> 
> Roman Rakus wrote:
>     And split it to parts. ORGID, CLASSNAME or so. And ORGID will be global for all providers.

I've added ORGID to the globals.h and CPU_CAP_CLASS_NAME to LMI_Hardware.h. element_name_string is used only in that one place, so I've made it const char * and kept it there.


- Peter


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/56/#review40
-----------------------------------------------------------


On March 26, 2013, 3:46 p.m., Peter Schiffer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-openlmi.rhcloud.com/r/56/
> -----------------------------------------------------------
> 
> (Updated March 26, 2013, 3:46 p.m.)
> 
> 
> Review request for OpenLMI Developers.
> 
> 
> Repository: openlmi-providers
> 
> 
> Description
> -------
> 
> Hardware: added new providers
> 
> Providers added:
>  * LMI_ProcessorCapabilitiesProvider
>  * LMI_ProcessorElementCapabilitiesProvider
> 
> 
> Diffs
> -----
> 
>   mof/LMI_Hardware.mof 4848ef1dbc40f5e01d496dcc893ac389d62aaa4f 
>   src/globals.h 6cf272ca9fbf08cde48ae67ff72b4bf71a9d9f4f 
>   src/hardware/CMakeLists.txt ebf79fb40869125ccb72dcd77a03038fa7066809 
>   src/hardware/LMI_Hardware.h PRE-CREATION 
>   src/hardware/LMI_ProcessorCapabilitiesProvider.c PRE-CREATION 
>   src/hardware/LMI_ProcessorElementCapabilitiesProvider.c PRE-CREATION 
>   src/hardware/LMI_ProcessorProvider.c 8e92fdd3ad0efc86287c19e93509559d3ed2cd49 
>   src/hardware/dmidecode.h f7e76a929bf19c481278a59c81e20a64201f75a7 
>   src/hardware/dmidecode.c 6a038fbe6a8b9acefbc1facafa2ee6a2195a0788 
>   src/hardware/lscpu.h 892141e2ff423ebc004091c8982565880b51265c 
>   src/hardware/lscpu.c 124ed7b81121ed9f2aabac4a7c2d49f7c65282e0 
> 
> Diff: http://reviewboard-openlmi.rhcloud.com/r/56/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Peter Schiffer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.fedorahosted.org/pipermail/openlmi-devel/attachments/20130326/6c074ba0/attachment-0001.html>


More information about the openlmi-devel mailing list