Review Request 39: Patch12: Added test for FileSystemConfigurationService.

Radek Novacek reviewboard at gallagherhome.com
Tue Mar 26 13:08:55 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/39/#review44
-----------------------------------------------------------

Ship it!


Ship It!


test/test_create_fs.py
<http://reviewboard-openlmi.rhcloud.com/r/39/#comment39>

    BTW: setUp is executed before each test, so 8 times in this module, you can save some execution time by moving this to setUpClass classmethod.
    
    But that is not really an issue...


- Radek Novacek


On March 22, 2013, 5:41 p.m., Jan Safranek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-openlmi.rhcloud.com/r/39/
> -----------------------------------------------------------
> 
> (Updated March 22, 2013, 5:41 p.m.)
> 
> 
> Review request for OpenLMI Developers.
> 
> 
> Repository: openlmi-storage
> 
> 
> Description
> -------
> 
> Added test for FileSystemConfigurationService.
> 
> 
> Diffs
> -----
> 
>   test/test_create_fs.py PRE-CREATION 
> 
> Diff: http://reviewboard-openlmi.rhcloud.com/r/39/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jan Safranek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.fedorahosted.org/pipermail/openlmi-devel/attachments/20130326/224cd88e/attachment.html>


More information about the openlmi-devel mailing list