Review Request 35: Patch08: Return device from get_format_for_id()

Radek Novacek reviewboard at gallagherhome.com
Mon Mar 25 16:23:32 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/35/#review36
-----------------------------------------------------------

Ship it!


Ship It!

- Radek Novacek


On March 22, 2013, 5:41 p.m., Jan Safranek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-openlmi.rhcloud.com/r/35/
> -----------------------------------------------------------
> 
> (Updated March 22, 2013, 5:41 p.m.)
> 
> 
> Review request for OpenLMI Developers.
> 
> 
> Repository: openlmi-storage
> 
> 
> Description
> -------
> 
> Return device from get_format_for_id()
> 
> In most cases, we need both the format and the device when working with
> device formats. Therefore get_format_for_id() shold return both.
> 
> 
> Diffs
> -----
> 
>   src/openlmi/storage/FormatProvider.py 72e81409ce13af899400a7c87e18711c9d63e8ff 
>   src/openlmi/storage/LMI_FileSystemConfigurationService.py 2a9c94d26cf63c86ce42edf681b6f0716cce7d1a 
>   src/openlmi/storage/LMI_MDRAIDFormatProvider.py b957ecbb4129a2aeebffedc98ac3406af032682c 
>   src/openlmi/storage/LMI_PVFormatProvider.py 5ec9d3634291d07366d778d3ccbc00b11297039a 
>   src/openlmi/storage/LocalFileSystemProvider.py b2558b81caa850b709024f21079033ea0ef1879c 
> 
> Diff: http://reviewboard-openlmi.rhcloud.com/r/35/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jan Safranek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.fedorahosted.org/pipermail/openlmi-devel/attachments/20130325/a2cd4f89/attachment.html>


More information about the openlmi-devel mailing list