Patch review for OpenLMI

Stephen Gallagher sgallagh at redhat.com
Mon Mar 11 18:47:23 UTC 2013


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Mon 11 Mar 2013 10:35:51 AM EDT, Jan Safranek wrote:
> Hi,
> 
> we've talked on Friday about starting code review for all OpenLMI 
> patches. Fedora 19 alpha freeze is here and it could be good
> milestone to start with reviews (or at least as good as any other
> milestone).
> 
> I would prefer as light review process as possible, we're still in 
> initial development where we code pretty quickly and I personally
> don't want to get slowed down by reviewing each patch
> character-by-character.
> 

I agree. While we're still in heavy development, we probably want to
limit our patch reviews to be ungated. (I.e. they shouldn't block
forever waiting for a review).

I'm inclined to suggest that we take the following approach:
Patches are sent to the openlmi-devel list as attachments.
If another developer reviews it and replies with "Ack", it can be
pushed immediately.
If another developer reviews it and replies with "Nack", it must be fixed.
If it's not reviewed within two business days, push it to master.


> @sgallahg, you mentioned some review tool, what was it and 
> where/when/how can we use it?


The review tool I was talking about was Review Board[1], and I'm
working on getting an instance of it hosted. I was planning to launch
it in an OpenShift instance today, but I'm having some issues with
their hosting (it looks like all of the static data like the CSS isn't
properly reachable, so it looks terrible).

I will sort this out and provide an update as soon as possible.

[1] http://www.reviewboard.org
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.13 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iEYEARECAAYFAlE+JrsACgkQeiVVYja6o6MAKwCfSlGu8OQWsh0bZjWLiCR6duyG
z4QAoKiTA//34cPaO8pKG6pBXf/1aIHs
=Pw4K
-----END PGP SIGNATURE-----


More information about the openlmi-devel mailing list