Review Request 670: openlmi-providers [1/1] Add logging to the openlmi-mof-register script

Radek Novacek reviewboard at gallagherhome.com
Thu Aug 1 14:37:04 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/670/
-----------------------------------------------------------

(Updated Aug. 1, 2013, 4:37 p.m.)


Review request for OpenLMI Developers.


Changes
-------

* bash time print
* no eval
* don't eat the exit code in 'log' function
* exit with trap
* whole if redirection in the spec


Repository: openlmi-providers


Description
-------

Add logging to the openlmi-mof-register script

Each command in the registration script is now logged into
/var/log/openlmi-install.log file.


Diffs (updated)
-----

  openlmi-mof-register 4e60e31786e22b063e4c3a42116e05038f5275c3 
  openlmi-providers.spec 0552a8cc01c8c3979a2304463f0a663fcc993a95 

Diff: http://reviewboard-openlmi.rhcloud.com/r/670/diff/


Testing
-------


Thanks,

Radek Novacek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.fedorahosted.org/pipermail/openlmi-devel/attachments/20130801/746361a9/attachment-0001.html>
-------------- next part --------------
_______________________________________________
openlmi-reviews mailing list
openlmi-reviews at lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/openlmi-reviews


More information about the openlmi-devel mailing list