Review Request 297: Hardware: Added additional information to the Memory provider

Peter Schiffer reviewboard at gallagherhome.com
Tue Apr 30 14:50:15 UTC 2013



> On April 30, 2013, 3:33 p.m., Radek Novacek wrote:
> > src/hardware/LMI_MemoryProvider.c, line 80
> > <http://reviewboard-openlmi.rhcloud.com/r/297/diff/1/?file=1808#file1808line80>
> >
> >     Return value of sysfs_get_sizes_of_hugepages should be checked

Return value doesn't need to be checked, because if it fails, the huge_page_sizes_nb will be 0, so nothing will change.


> On April 30, 2013, 3:33 p.m., Radek Novacek wrote:
> > src/hardware/sysfs.c, line 349
> > <http://reviewboard-openlmi.rhcloud.com/r/297/diff/1/?file=1811#file1811line349>
> >
> >     I don't understand what this code means. It seems that it's trying to read number from tenth position in the dirent's d_name. Is it correct?

Correct. I'll add a comment to that line of code.


- Peter


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/297/#review342
-----------------------------------------------------------


On April 30, 2013, 3:16 p.m., Peter Schiffer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-openlmi.rhcloud.com/r/297/
> -----------------------------------------------------------
> 
> (Updated April 30, 2013, 3:16 p.m.)
> 
> 
> Review request for OpenLMI Developers.
> 
> 
> Repository: openlmi-providers
> 
> 
> Description
> -------
> 
> Hardware: Added additional information to the Memory provider
> 
> Added information:
>  * detect NUMA layout
>  * standard memory page size
>  * all supported sizes of huge memory pages
>  * current state of transparent huge pages
> 
> 
> Diffs
> -----
> 
>   mof/60_LMI_Hardware.mof 63c1a74222f32c8f38a3c083a05a255936526ae6 
>   src/hardware/LMI_MemoryProvider.c 0d77c171972567e7077520ff533527ff4eae0164 
>   src/hardware/dmidecode.c f034b56166debe2aa1bc9bc5a0488beaf74055ae 
>   src/hardware/sysfs.h 028b55925c7462aa55be1a4fc8cfcf9abf5172e0 
>   src/hardware/sysfs.c d07df71aeb0d44129c9d03ad74c80aa985a9edf6 
> 
> Diff: http://reviewboard-openlmi.rhcloud.com/r/297/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Peter Schiffer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.fedorahosted.org/pipermail/openlmi-devel/attachments/20130430/bd96a958/attachment-0001.html>


More information about the openlmi-devel mailing list